From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org,
Florian Achleitner <florian.achleitner.2.6.31@gmail.com>
Subject: Re: [PATCH] pager: drop "wait for output to run less" hack
Date: Tue, 5 Jun 2012 11:50:07 -0400 [thread overview]
Message-ID: <20120605155007.GA20494@sigill.intra.peff.net> (raw)
In-Reply-To: <7vwr3lpxyh.fsf@alter.siamese.dyndns.org>
On Tue, Jun 05, 2012 at 08:42:14AM -0700, Junio C Hamano wrote:
> > I'm really tempted to do this:
>
> Why (I am slower than my usual slow self today, so pardon me)?
Purely to clean up the nasty preexec thing, which is a hack, and should
never be used for new code due to portability issues.
> Aren't these already protected with "ifndef WIN32"?
Yes, but it means anything that uses it will not work on Windows.
> > I checked, and even RHEL5 is on less 436. So besides people on antique
> > "I installed less from source more than 5 years ago" systems, my only
> > concern would be that some other pager depends on this hack in a weird
> > way. But I have never heard of such a thing, so...
>
> Hrm...
Yeah. This is purely a cleanup thing. It's a cleanup I've wanted to do
for a long time (ever since adding it), but it is not hurting anyone
as-is. We can always just reject new uses of preexec_cb in review (which
is more or less what I'm doing here).
-Peff
next prev parent reply other threads:[~2012-06-05 15:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-05 8:56 [PATCH] pager: drop "wait for output to run less" hack Jeff King
2012-06-05 15:42 ` Junio C Hamano
2012-06-05 15:50 ` Jeff King [this message]
2012-06-05 15:52 ` Erik Faye-Lund
2012-06-05 16:01 ` Jeff King
2012-06-05 16:36 ` Junio C Hamano
2012-06-05 16:45 ` Jeff King
2012-06-05 23:09 ` Erik Faye-Lund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120605155007.GA20494@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=florian.achleitner.2.6.31@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).