From: Jeff King <peff@peff.net>
To: Erik Faye-Lund <kusmabite@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org,
Florian Achleitner <florian.achleitner.2.6.31@gmail.com>
Subject: Re: [PATCH] pager: drop "wait for output to run less" hack
Date: Tue, 5 Jun 2012 12:01:57 -0400 [thread overview]
Message-ID: <20120605160157.GA20582@sigill.intra.peff.net> (raw)
In-Reply-To: <CABPQNSbhgan+i_Q142R8VvRdJ5T+GyYHqgEJ6KS-BBJguRu-OQ@mail.gmail.com>
On Tue, Jun 05, 2012 at 05:52:24PM +0200, Erik Faye-Lund wrote:
> On Tue, Jun 5, 2012 at 10:56 AM, Jeff King <peff@peff.net> wrote:
> > I checked, and even RHEL5 is on less 436. So besides people on antique
> > "I installed less from source more than 5 years ago" systems, my only
> > concern would be that some other pager depends on this hack in a weird
> > way. But I have never heard of such a thing, so...
>
> On my RHEL5 box at work:
> $ less --version
> less 394
> Copyright (C) 1984-2005 Mark Nudelman
Then I think you are not following the bug-fix updates, as they've
issued several updates based on 436:
https://rhn.redhat.com/errata/RHBA-2010-0214.html
https://rhn.redhat.com/errata/RHBA-2010-0805.html
http://rhn.redhat.com/errata/RHBA-2011-1468.html
Looks like 394 was shipping as recently as 2009:
https://rhn.redhat.com/errata/RHBA-2009-0413.html
Given that the buggy less is apparently still in the wild, and that the
patch is a pure cleanup, I guess we should scrap it for now. <sigh>
-Peff
next prev parent reply other threads:[~2012-06-05 16:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-05 8:56 [PATCH] pager: drop "wait for output to run less" hack Jeff King
2012-06-05 15:42 ` Junio C Hamano
2012-06-05 15:50 ` Jeff King
2012-06-05 15:52 ` Erik Faye-Lund
2012-06-05 16:01 ` Jeff King [this message]
2012-06-05 16:36 ` Junio C Hamano
2012-06-05 16:45 ` Jeff King
2012-06-05 23:09 ` Erik Faye-Lund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120605160157.GA20582@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=florian.achleitner.2.6.31@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kusmabite@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).