From: Jonathan Nieder <jrnieder@gmail.com>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [RFC/PATCH] parse-options: introduce parse_subcommands
Date: Tue, 5 Jun 2012 18:32:57 -0500 [thread overview]
Message-ID: <20120605233257.GG3619@burratino> (raw)
In-Reply-To: <1338802534-32394-1-git-send-email-artagnon@gmail.com>
Hi,
Ramkumar Ramachandra wrote:
> $ git notes foo
> error: Unknown subcommand: foo
> usage: git notes [--ref <notes_ref>] [list [<object>]]
> or: git notes [--ref <notes_ref>] add [-f] [-m <msg> | -F <file> | (-c | -C) <object>] [<object>]
> or: git notes [--ref <notes_ref>] copy [-f] <from-object> <to-object>
[...]
> is replaced by a more helpful:
>
> $ git notes foo
> error: unknown subcommand: foo
> usage: git notes [<options>] [<subcommand>] [<options>] [<object>..]
>
> available subcommands:
> list list notes for given object
> add add notes for given object
> copy copy notes for first object onto second object
> append append notes to existing object
> edit edit notes for given object
> show show notes for given object
> merge merge given notes ref into current notes ref
> remove remove notes for given objects
> prune remove all notes for non-existing/unreachable objects
> get-ref print the current notes ref
The goal looks good. As Junio said, the code looks simplifiable.
Hope that helps,
Jonathan
prev parent reply other threads:[~2012-06-05 23:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-04 9:35 [RFC/PATCH] parse-options: introduce parse_subcommands Ramkumar Ramachandra
2012-06-04 17:01 ` Junio C Hamano
2012-06-06 14:10 ` Ramkumar Ramachandra
2012-06-06 17:26 ` Junio C Hamano
2012-06-08 8:56 ` [RFC] notes: attach help text to subcommands Ramkumar Ramachandra
2012-06-08 14:49 ` Junio C Hamano
2012-06-08 15:28 ` [PATCH] " Ramkumar Ramachandra
2012-06-08 15:36 ` Jonathan Nieder
2012-06-08 15:54 ` Felipe Contreras
2012-06-08 16:34 ` Ramkumar Ramachandra
2012-06-13 15:04 ` Felipe Contreras
2012-06-08 17:03 ` Junio C Hamano
2012-06-05 23:32 ` Jonathan Nieder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120605233257.GG3619@burratino \
--to=jrnieder@gmail.com \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).