From: Jonathan Nieder <jrnieder@gmail.com>
To: Heiko Voigt <hvoigt@hvoigt.net>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Jeff King <peff@peff.net>
Subject: Re: [PATCH] lessen the impression of unexpectedness on remote hangup
Date: Sun, 10 Jun 2012 13:44:10 -0500 [thread overview]
Message-ID: <20120610184410.GA1115@burratino> (raw)
In-Reply-To: <20120610182310.GB2427@book.hvoigt.net>
Hi,
Heiko Voigt wrote:
> --- a/pkt-line.c
> +++ b/pkt-line.c
> @@ -141,7 +141,7 @@ static void safe_read(int fd, void *buffer, unsigned size)
> if (ret < 0)
> die_errno("read error");
> else if (ret < size)
> - die("The remote end hung up unexpectedly");
> + die("The remote end hung up");
Looks good. Incidentally, maybe this would be a good excuse to
revisit [1].
If I remember correctly, the conclusion of that discussion was that
--informative-errors is a good default for the git daemon as long as
- there is some warning when using it without --base-path
- there is an easy way to turn it off
- we communicate the change clearly and in advance
Hope that helps,
Jonathan
[1] http://thread.gmane.org/gmane.comp.version-control.git/183604
next prev parent reply other threads:[~2012-06-10 18:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-10 18:23 [PATCH] lessen the impression of unexpectedness on remote hangup Heiko Voigt
2012-06-10 18:44 ` Jonathan Nieder [this message]
2012-06-11 16:41 ` Junio C Hamano
2012-06-11 19:02 ` Jeff King
2012-06-13 21:28 ` Heiko Voigt
2012-06-14 7:13 ` [PATCH] remove the impression of unexpectedness when access is denied Heiko Voigt
2012-06-14 7:39 ` Heiko Voigt
2012-06-14 17:11 ` Junio C Hamano
2012-06-14 20:37 ` Heiko Voigt
2012-06-19 18:24 ` [PATCH v2] " Heiko Voigt
2013-05-04 3:10 ` Jonathan Nieder
2013-05-06 14:02 ` Junio C Hamano
2013-05-07 18:39 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120610184410.GA1115@burratino \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hvoigt@hvoigt.net \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).