From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: vfr@lyx.org, git@vger.kernel.org, gitster@pobox.om
Subject: Re: [PATCH] t: Replace 'perl' by $PERL_PATH
Date: Tue, 12 Jun 2012 08:34:54 -0400 [thread overview]
Message-ID: <20120612123454.GA25407@sigill.intra.peff.net> (raw)
In-Reply-To: <7v1ull7j9k.fsf@alter.siamese.dyndns.org>
On Mon, Jun 11, 2012 at 12:15:03PM -0700, Junio C Hamano wrote:
> There was already this discussion:
>
> http://thread.gmane.org/gmane.comp.version-control.git/132560/focus=132561
>
> which basically dismissed effort along this line with "If the perl
> in your PATH is so broken that it can't be used for simple helpers,
> then you should fix your PATH."
That sounds like something I would say. :)
> I personally do not mind if we do this consistently, but I am not
> sure your $PERL_PATH that is not quoted is the right way to invoke
> it; look for PERL_PATH in t/ to see the existing uses.
My biggest concern is placing an extra portability burden on
test-writers (who will inevitably forget, and won't notice because what
they are doing is only broken on obscure systems). Is there a way we can
hide this behind a perl() shell function or something?
-Peff
next prev parent reply other threads:[~2012-06-12 12:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-11 19:01 [PATCH] t: Replace 'perl' by $PERL_PATH vfr
2012-06-11 19:15 ` Junio C Hamano
2012-06-12 12:34 ` Jeff King [this message]
2012-06-12 14:56 ` Junio C Hamano
2012-06-12 14:59 ` Jeff King
2012-06-12 15:36 ` Erik Faye-Lund
2012-06-12 16:08 ` Junio C Hamano
2012-06-12 16:44 ` Junio C Hamano
2012-06-12 17:05 ` Jeff King
2012-06-12 19:29 ` Vincent van Ravesteijn
2012-06-17 6:36 ` Torsten Bögershausen
2012-06-17 7:15 ` Junio C Hamano
2012-06-17 8:50 ` Torsten Bögershausen
2012-06-17 22:23 ` Junio C Hamano
2012-06-20 20:16 ` Torsten Bögershausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120612123454.GA25407@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=gitster@pobox.om \
--cc=vfr@lyx.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).