From: Jeff King <peff@peff.net>
To: Luka Perkov <lists@lukaperkov.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-http-fetch: remove unused cmd_http_fetch
Date: Fri, 15 Jun 2012 12:21:36 -0400 [thread overview]
Message-ID: <20120615162136.GC4572@sigill.intra.peff.net> (raw)
In-Reply-To: <20120614202336.GA3755@w500.iskon.local>
On Thu, Jun 14, 2012 at 10:23:37PM +0200, Luka Perkov wrote:
> It was left out from commit 1088261f6fc90324014b5306cca4171987da85ce
This commit message left me scratching my head. Did we get rid of
http-fetch? If not, then don't we still need cmd_http_fetch? Or did we
just make it not a builtin, in which case we wouldn't be getting rid of
cmd_http_fetch, but rather converting it to main?
Reading the 1088261, I find the answer: we did make it not a builtin,
and it was indeed converted into "main". But its _declaration_ hung
around.
So maybe a better commit message would be:
Subject: builtin.h: drop cmd_http_fetch declaration
This was converted from a builtin into a stand-alone program by
1088261f6fc90324014b5306cca4171987da85ce, but that commit forgot to
drop the declaration.
Other than that, the patch looks obviously correct.
-Peff
PS There seem to be some other similar declarations: at least
cmd_upload_tar and cmd_pickaxe.
next prev parent reply other threads:[~2012-06-15 16:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 20:23 [PATCH] git-http-fetch: remove unused cmd_http_fetch Luka Perkov
2012-06-15 16:21 ` Jeff King [this message]
2012-06-15 18:09 ` Junio C Hamano
2012-06-15 18:16 ` Jeff King
2012-06-15 18:40 ` Luka Perkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120615162136.GC4572@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=lists@lukaperkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).