From: Jonathan Nieder <jrnieder@gmail.com>
To: Adam Roben <adam@roben.org>
Cc: git@vger.kernel.org, "Eric Wong" <normalperson@yhbt.net>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: [PATCH 2/1] perl/Makefile.PL: warn about duplicate module list in perl/Makefile
Date: Fri, 15 Jun 2012 13:14:46 -0500 [thread overview]
Message-ID: <20120615181446.GI10752@burratino> (raw)
In-Reply-To: <20120615180505.GH10752@burratino>
Adding or removing a module requires modifying both files to support
builds with and without MakeMaker. Add a comment to remind patch
authors and reviewers at the crucial moment.
Longer term, it would be nicer to maintain a single list, perhaps in a
separate file used by both build systems.
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
---
perl/Makefile.PL | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/perl/Makefile.PL b/perl/Makefile.PL
index 2c20290f..b54b04a6 100644
--- a/perl/Makefile.PL
+++ b/perl/Makefile.PL
@@ -24,6 +24,10 @@ endif
MAKE_FRAG
}
+# XXX. When editing this list:
+#
+# * Please update perl/Makefile, too.
+# * Don't forget to test with NO_PERL_MAKEMAKER=YesPlease
my %pm = (
'Git.pm' => '$(INST_LIBDIR)/Git.pm',
'Git/I18N.pm' => '$(INST_LIBDIR)/Git/I18N.pm',
--
1.7.10.4
next prev parent reply other threads:[~2012-06-15 18:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1339781427-10568-1-git-send-email-adam@roben.org>
2012-06-15 18:05 ` [PATCH] Fix git-svn in non-MakeMaker builds Jonathan Nieder
2012-06-15 18:14 ` Jonathan Nieder [this message]
2012-06-15 20:23 ` [PATCH 2/1] perl/Makefile.PL: warn about duplicate module list in perl/Makefile Junio C Hamano
2012-06-15 21:25 ` [PATCH] Fix git-svn in non-MakeMaker builds Junio C Hamano
2012-06-15 23:02 ` [PATCH] perl/Makefile: move "mkdir -p" to module installation loop for maintainability Jonathan Nieder
2012-06-15 23:10 ` Junio C Hamano
2012-06-29 8:07 ` [PATCH jn/perl-makemaker-leading-paths] perl/Makefile: Fix a missing double-quote Johannes Sixt
2012-06-29 8:55 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120615181446.GI10752@burratino \
--to=jrnieder@gmail.com \
--cc=adam@roben.org \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=normalperson@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).