From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeff King <peff@peff.net>
Subject: Re: [PATCH 2/4] version: add git_user_agent function
Date: Tue, 19 Jun 2012 14:59:16 -0400
Message-ID: <20120619185916.GA16429@sigill.intra.peff.net>
References: <20120602184948.GA14269@sigill.intra.peff.net>
 <20120602190112.GB14369@sigill.intra.peff.net>
 <87pq8vrvqz.fsf@thomas.inf.ethz.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
To: Thomas Rast <trast@student.ethz.ch>
X-From: git-owner@vger.kernel.org Tue Jun 19 20:59:25 2012
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git-2@plane.gmane.org
Received: from vger.kernel.org ([209.132.180.67])
	by plane.gmane.org with esmtp (Exim 4.69)
	(envelope-from <git-owner@vger.kernel.org>)
	id 1Sh3e7-0006lm-QT
	for gcvg-git-2@plane.gmane.org; Tue, 19 Jun 2012 20:59:24 +0200
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753122Ab2FSS7U (ORCPT <rfc822;gcvg-git-2@m.gmane.org>);
	Tue, 19 Jun 2012 14:59:20 -0400
Received: from 99-108-225-23.lightspeed.iplsin.sbcglobal.net ([99.108.225.23]:32908
	"EHLO peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750955Ab2FSS7T (ORCPT <rfc822;git@vger.kernel.org>);
	Tue, 19 Jun 2012 14:59:19 -0400
Received: (qmail 12249 invoked by uid 107); 19 Jun 2012 18:59:18 -0000
Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7)
  (smtp-auth username relayok, mechanism cram-md5)
  by peff.net (qpsmtpd/0.84) with ESMTPA; Tue, 19 Jun 2012 14:59:18 -0400
Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Tue, 19 Jun 2012 14:59:16 -0400
Content-Disposition: inline
In-Reply-To: <87pq8vrvqz.fsf@thomas.inf.ethz.ch>
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/200226>

On Tue, Jun 19, 2012 at 08:40:04PM +0200, Thomas Rast wrote:

> I'm terribly late to the party, seeing as this is already in next, but:

It's never too late.

> > +GIT_USER_AGENT = git/$(GIT_VERSION)
> ...
> > +GIT_USER_AGENT_SQ = $(subst ','\'',$(GIT_USER_AGENT))
> > +GIT_USER_AGENT_CQ = "$(subst ",\",$(subst \,\\,$(GIT_USER_AGENT)))"
> > +GIT_USER_AGENT_CQ_SQ = $(subst ','\'',$(GIT_USER_AGENT_CQ))
> > +BASIC_CFLAGS += -DGIT_USER_AGENT='$(GIT_USER_AGENT_CQ_SQ)'
> 
> Unless the user manually sets GIT_USER_AGENT, This forces a full rebuild
> due to changed CFLAGS whenever the version changes.  Can you make it so
> that only version.o needs to be rebuilt, as with the normal git version
> string?

Ick, yeah. I had though this was already the case, but it turns out that
it was a peculiarity of my personal config.mak (I set a custom $prefix
based on the branch, and it has a similar problem). I'll see if I can
fix both.

-Peff