From: Jonathan Nieder <jrnieder@gmail.com>
To: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 2/2] Add C_LOCALE_OUTPUT prereq to test cases that require English text matching
Date: Mon, 25 Jun 2012 06:53:17 -0500 [thread overview]
Message-ID: <20120625115317.GC9270@burratino> (raw)
In-Reply-To: <CACsJy8BMizkU+P6VPhkbY_q2tYY5=aY-GNHeDjBYN9-zg2nENQ@mail.gmail.com>
Nguyen Thai Ngoc Duy wrote:
> What if we allow to run the test suite in non-C locales and skip the
> tests that require C_LOCALE_OUTPUT? In non-C locales, we won't set
> C_LOCALE_OUTPUT prerequisite. This allows to test a localized git with
> ~90% of the test suite. Would it work?
Yes, of course, modulo bugs. :) I guess one thing to watch out for
would be assumptions about non-git utilities in the test suite --- for
example, some commands such as "sed" have a different idea of what a
character is in other locales. But the main ingredient needed is just
UI (a test option or envvar).
next prev parent reply other threads:[~2012-06-25 11:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-24 12:41 [PATCH 1/2] i18n: leave \n out of translated diffstat Nguyễn Thái Ngọc Duy
2012-06-24 12:41 ` [PATCH 2/2] Add C_LOCALE_OUTPUT prereq to test cases that require English text matching Nguyễn Thái Ngọc Duy
2012-06-24 16:28 ` Jonathan Nieder
2012-06-25 11:32 ` Nguyen Thai Ngoc Duy
2012-06-25 11:39 ` Jonathan Nieder
2012-06-25 11:45 ` Nguyen Thai Ngoc Duy
2012-06-25 11:53 ` Jonathan Nieder [this message]
2012-06-24 16:04 ` [PATCH 1/2] i18n: leave \n out of translated diffstat Jonathan Nieder
2012-06-25 4:24 ` Junio C Hamano
2012-06-25 11:17 ` Nguyen Thai Ngoc Duy
2012-06-25 11:33 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120625115317.GC9270@burratino \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).