From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Webb Subject: Re: [PATCH 1/2] rebase -i: support --root without --onto Date: Tue, 26 Jun 2012 21:11:56 +0100 Message-ID: <20120626201155.GE5864@arachsys.com> References: <20120626133339.GT9682@arachsys.com> <7vtxxxc22x.fsf@alter.siamese.dyndns.org> <20120626193817.GD30779@arachsys.com> <7vfw9hbzz5.fsf@alter.siamese.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: git@vger.kernel.org, Jeff King To: Junio C Hamano X-From: git-owner@vger.kernel.org Tue Jun 26 22:12:07 2012 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Sjc7K-0000um-CB for gcvg-git-2@plane.gmane.org; Tue, 26 Jun 2012 22:12:06 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751946Ab2FZUMA (ORCPT ); Tue, 26 Jun 2012 16:12:00 -0400 Received: from alpha.arachsys.com ([91.203.57.7]:39888 "EHLO alpha.arachsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751079Ab2FZUMA (ORCPT ); Tue, 26 Jun 2012 16:12:00 -0400 Received: from [81.2.114.212] (helo=arachsys.com) by alpha.arachsys.com with esmtpa (Exim 4.72) (envelope-from ) id 1Sjc7C-0002dS-Ui; Tue, 26 Jun 2012 21:11:59 +0100 Content-Disposition: inline In-Reply-To: <7vfw9hbzz5.fsf@alter.siamese.dyndns.org> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Junio C Hamano writes: > Very understandable. Perhaps in-code comments would have helped. Shall I re-spin this with a comment to explain what's going on, and to mention the implicit -i with rebase --root without -i, or would you prefer to queue the existing version with any clarifications you think appropriate? Best wishes, Chris.