From: Jeff King <peff@peff.net>
To: Chris Webb <chris@arachsys.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH 2/3] Allow help.htmlpath to be an http: URL
Date: Thu, 28 Jun 2012 13:50:41 -0400 [thread overview]
Message-ID: <20120628175041.GA4731@sigill.intra.peff.net> (raw)
In-Reply-To: <20120628065623.GB1742@arachsys.com>
On Thu, Jun 28, 2012 at 07:56:23AM +0100, Chris Webb wrote:
> > This, and "://", both sound sensible.
>
> I have no real preference between any of the suggestions so far: they'd all
> be completely fine with me. Peff's :// test for a URL is much better than my
> http: prefix, so should replace the latter if we need a test at all, but
> apart from that I don't mind at all.
>
> Okay, I'll re-send now the :// version I did in response to Peff's first
> email purely on the basis that it doesn't change the behaviour at all for
> existing users who don't set htmlpath at all, plus it's already sat in my
> reflog!
I think the "://" one is my preference. I just looked over your v3
series, and the patches look good to me.
-Peff
next prev parent reply other threads:[~2012-06-28 17:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-27 20:54 A handful of help-related patches Chris Webb
2012-06-27 20:55 ` [PATCH 1/3] Add config variable to set HTML path for git-help --web Chris Webb
2012-06-27 20:55 ` [PATCH 2/3] Allow help.htmlpath to be an http: URL Chris Webb
2012-06-27 21:05 ` Jeff King
2012-06-27 21:12 ` Chris Webb
2012-06-27 21:32 ` Junio C Hamano
2012-06-27 21:41 ` Chris Webb
2012-06-27 22:11 ` Jeff King
2012-06-27 22:19 ` Chris Webb
2012-06-27 22:52 ` Jeff King
2012-06-28 2:41 ` Junio C Hamano
2012-06-28 6:56 ` Chris Webb
2012-06-28 17:50 ` Jeff King [this message]
2012-06-28 23:39 ` Chris Webb
2012-06-27 20:55 ` [PATCH 3/3] Add a help format 'usage' to provide brief command usage Chris Webb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120628175041.GA4731@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=chris@arachsys.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).