Re: Apostrophe at the end of author name

[Jeff King <peff@peff.net>]

On Fri, Jun 29, 2012 at 08:17:01PM +0200, Kacper Kornet wrote:

> >  as strbuf_addstr_without_crud was
> > only added recently (but it is a refactoring of older code which should
> > have the same behavior).
> 
> It depends what you call recently. It was refactored in July 2005
> (commit: 6aa33f4035d5). But it looks like the previous code (before
> refactoring) removed only comma, dot and semicolon from the end of the
> author name.

I meant the name strbuf_addstr_without_crud did not exist until I added
it in c96f0c8, about a month ago. But yes, the functionality of the code
has been there since the very early days.

I'm tempting by the patch below, which would remove only the
syntactically significant meta-characters ("\n", "<", and ">"), as well
as trimming any stray whitespace at the edges. The problem is that we
don't really have a clue how many people were relying on this trimming
to clean up their names or emails, so there may be regressions for other
people.

diff --git a/ident.c b/ident.c
index 443c075..4552f8d 100644
--- a/ident.c
+++ b/ident.c
@@ -127,15 +127,8 @@ const char *ident_default_date(void)
 static int crud(unsigned char c)
 {
 	return  c <= 32  ||
-		c == '.' ||
-		c == ',' ||
-		c == ':' ||
-		c == ';' ||
 		c == '<' ||
-		c == '>' ||
-		c == '"' ||
-		c == '\\' ||
-		c == '\'';
+		c == '>';
 }
 
 /*