From: Chris Webb <chris@arachsys.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: Using git commit --amend on a commit with an empty message
Date: Mon, 9 Jul 2012 19:17:55 +0100 [thread overview]
Message-ID: <20120709181754.GE23859@arachsys.com> (raw)
In-Reply-To: <7v7guclucl.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
> Yeah, it is a "bug" that exists only because nobody sane uses empty
> message commits, let alone tries to amend such commits, hence went
> unnoticed for a long time.
Quite. I only noticed it because this is the default behaviour of Github
gists and I wanted to replace the empty commit messages with more meaningful
ones.
> The patch looks sane; if we want to keep this as a feature or a
> bugfix, we may want to pretect it with a new test, though.
Yes, it's hardly something people will test often. Okay, I'll send a version
two with a suitable test.
Best wishes,
Chris.
next prev parent reply other threads:[~2012-07-09 18:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-09 14:24 Using git commit --amend on a commit with an empty message Chris Webb
2012-07-09 17:25 ` Junio C Hamano
2012-07-09 18:17 ` Chris Webb [this message]
2012-07-09 18:53 ` [PATCH v2] Allow edit of empty message with commit --amend Chris Webb
2012-07-09 19:43 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120709181754.GE23859@arachsys.com \
--to=chris@arachsys.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).