From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Alex Riesen <raa.lkml@gmail.com>,
git@vger.kernel.org, Daniel Barkalow <barkalow@iabervon.org>
Subject: Re: [PATCH] Restore umasks influence on the permissions of work tree created by clone
Date: Mon, 9 Jul 2012 18:58:29 -0400 [thread overview]
Message-ID: <20120709225829.GA8397@sigill.intra.peff.net> (raw)
In-Reply-To: <7vobnpn224.fsf@alter.siamese.dyndns.org>
On Sun, Jul 08, 2012 at 06:41:39PM -0700, Junio C Hamano wrote:
> Alex Riesen <raa.lkml@gmail.com> writes:
>
> > The original (shell coded) version of the git-clone just used mkdir(1)
> > to create the working directories. The builtin changed the mode argument
> > to mkdir(2) to 0755, which was a bit unfortunate, as there are use
>
> A much more important reason why this is a good change (I think you
> could even say this is a bugfix) is because directories and files in
> the working tree are created with entry.c::create_directories() and
> entry.c::create_file(), and they do honour umask settings, and the
> top-level of the working tree should be handled the same way, no?
Does the mkdir of "rr-cache/*" in rerere.c make the same mistake? The
rr-cache root is made with 0777, and the files inside each subdirectory
are created with 0666. So it is the only thing preventing users of
shared repos from using rerere.
-Peff
next prev parent reply other threads:[~2012-07-09 22:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-06 19:27 git-clone ignores umask for working tree Alex Riesen
2012-07-06 21:20 ` Daniel Barkalow
2012-07-07 21:50 ` [PATCH] Restore umasks influence on the permissions of work tree created by clone Alex Riesen
2012-07-09 1:41 ` Junio C Hamano
2012-07-09 18:21 ` Alex Riesen
2012-07-09 22:58 ` Jeff King [this message]
2012-07-09 23:07 ` Junio C Hamano
2012-07-09 23:18 ` Junio C Hamano
2012-07-09 23:28 ` [PATCH] rerere: make rr-cache fanout directory honor umask Junio C Hamano
2012-07-10 6:37 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120709225829.GA8397@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).