From: Alexander Strasser <eclipse7@gmx.net>
To: "Zbigniew Jędrzejewski-Szmek" <zbyszek@in.waw.pl>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Johannes Sixt <j6t@kdbg.org>
Subject: Re: [PATCH 3/6] t4012: Actually quote the sed script
Date: Fri, 13 Jul 2012 00:26:52 +0200 [thread overview]
Message-ID: <20120712222652.GB2782@akuma> (raw)
In-Reply-To: <4FFEBFE2.5030206@in.waw.pl>
Hi Zbigniew,
Zbigniew Jędrzejewski-Szmek wrote:
> On 07/12/2012 12:12 AM, Alexander Strasser wrote:
[...]
> I have some spelling corrections (minor, but since you intend to re-roll
> anyway, I'll post them), and one more thing which could be corrected
> (below).
>
> 3/6: s/Never the less/Nevertheless/
> 4/6: s/masquerading/masking/ (masquerade means to "mask oneself")
[...]
> > if git apply --stat --summary broken 2>detected
> > then
> > echo unhappy - should have detected an error
> I think this can be changed to:
> test_must_fail git apply --stat --summary broken 2>detected
Thank you for your sharp feedback. I will implement the requested
changes for the re-roll.
Alexander
prev parent reply other threads:[~2012-07-12 22:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-11 22:12 [PATCH 3/6] t4012: Actually quote the sed script Alexander Strasser
2012-07-12 12:15 ` Zbigniew Jędrzejewski-Szmek
2012-07-12 22:26 ` Alexander Strasser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120712222652.GB2782@akuma \
--to=eclipse7@gmx.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=zbyszek@in.waw.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).