From: Jonathan Nieder <jrnieder@gmail.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Michael Cree <mcree@orcon.net.nz>,
git@vger.kernel.org, Nicolas Pitre <nico@fluxnic.net>
Subject: [PATCH] block-sha1: put macro arguments in parentheses
Date: Sat, 14 Jul 2012 16:57:49 -0500 [thread overview]
Message-ID: <20120714215749.GE28502@burratino> (raw)
In-Reply-To: <CA+55aFxHAPJi9cKVy6Mi7gunHT3PPLEQUwJBFQ4ftO2szc_dow@mail.gmail.com>
't' is currently always a numeric constant, but it can't hurt to
prepare for the day that it becomes useful for a caller to pass in a
more complex expression.
Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
---
block-sha1/sha1.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block-sha1/sha1.c b/block-sha1/sha1.c
index 10fd94d1..6f885c43 100644
--- a/block-sha1/sha1.c
+++ b/block-sha1/sha1.c
@@ -100,8 +100,8 @@
* Where do we get the source from? The first 16 iterations get it from
* the input data, the next mix it from the 512-bit array.
*/
-#define SHA_SRC(t) get_be32((unsigned char *) block + t*4)
-#define SHA_MIX(t) SHA_ROL(W(t+13) ^ W(t+8) ^ W(t+2) ^ W(t), 1)
+#define SHA_SRC(t) get_be32((unsigned char *) block + (t)*4)
+#define SHA_MIX(t) SHA_ROL(W((t)+13) ^ W((t)+8) ^ W((t)+2) ^ W(t), 1);
#define SHA_ROUND(t, input, fn, constant, A, B, C, D, E) do { \
unsigned int TEMP = input(t); setW(t, TEMP); \
--
1.7.10.4
next prev parent reply other threads:[~2012-07-14 21:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120713233957.6928.87541.reportbug@electro.phys.waikato.ac.nz>
[not found] ` <20120714002950.GA3159@burratino>
[not found] ` <5000CBCA.8020607@orcon.net.nz>
[not found] ` <20120714021856.GA3062@burratino>
[not found] ` <50010B84.5030606@orcon.net.nz>
2012-07-14 7:59 ` [PATCH maint-1.6.5] block-sha1: avoid unaligned accesses on some big-endian systems Jonathan Nieder
2012-07-14 19:11 ` Linus Torvalds
2012-07-14 19:50 ` Jonathan Nieder
2012-07-14 19:55 ` Linus Torvalds
2012-07-14 20:50 ` [PATCH maint-1.6.5 v2] block-sha1: avoid pointer conversion that violates alignment constraints Jonathan Nieder
2012-07-14 20:56 ` Linus Torvalds
2012-07-14 21:57 ` Jonathan Nieder [this message]
2012-07-15 20:58 ` Michael Cree
2012-07-15 21:27 ` Jonathan Nieder
2012-07-16 9:53 ` Michael Cree
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120714215749.GE28502@burratino \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=mcree@orcon.net.nz \
--cc=nico@fluxnic.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).