From: Jonathan Nieder <jrnieder@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Andreas Schwab <schwab@linux-m68k.org>,
"Shawn O. Pearce" <spearce@spearce.org>,
David Barr <davidbarr@google.com>, Felix Natter <fnatter@gmx.net>,
git@vger.kernel.org
Subject: Re: [PATCH] fast-import: catch deletion of non-existent file in input
Date: Sun, 15 Jul 2012 13:11:51 -0500 [thread overview]
Message-ID: <20120715181151.GA1986@burratino> (raw)
In-Reply-To: <20120715102300.GA28667@sigill.intra.peff.net>
Hi,
Jeff King wrote:
> Subject: fast-import: catch deletion of non-existent file in input
[...]
> We silently ignored the bogus "D foo" directive, and the
> resulting tree incorrectly contained "bar". With this patch,
> we notice the bogus input and die.
This breaks svn-fe, which relies on the existing semantics when asked
to copy an empty directory.
That's my fault because we never check that in the testsuite, but I
also wouldn't be surprised if other importers were relying on the same
thing.
Any API break this big without a justification along the lines
We can be confident that no existing importer uses this
construct because ...
_needs_ to be guarded by a new "feature" to be safe for existing
importers.
Let's repeat that for emphasis: API breaks in fast-import not guarded
with a new "feature" type are not ok.
Sorry,
Jonathan
next prev parent reply other threads:[~2012-07-15 18:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 18:00 Export from bzr / Import to git results in a deleted file re-appearing Felix Natter
2012-07-12 21:01 ` Jeff King
2012-07-13 9:04 ` Andreas Schwab
2012-07-13 13:02 ` Jeff King
2012-07-13 13:39 ` Andreas Schwab
2012-07-14 14:33 ` Felix Natter
2012-07-15 10:23 ` [PATCH] fast-import: catch deletion of non-existent file in input Jeff King
2012-07-15 18:11 ` Jonathan Nieder [this message]
2012-07-16 0:26 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120715181151.GA1986@burratino \
--to=jrnieder@gmail.com \
--cc=davidbarr@google.com \
--cc=fnatter@gmx.net \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=schwab@linux-m68k.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).