From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jukka Lehtniemi <jukka.lehtniemi@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH v2] Fix notes handling in rev-list
Date: Mon, 16 Jul 2012 23:51:38 -0400 [thread overview]
Message-ID: <20120717035138.GC20945@sigill.intra.peff.net> (raw)
In-Reply-To: <7v1ukbys0n.fsf@alter.siamese.dyndns.org>
On Mon, Jul 16, 2012 at 08:40:24PM -0700, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > ... But whatever we call it, I think it is an
> > improvement.
>
> I didn't say it makes things worse in any way, did I?
No, you did not. That was my attempt to end the paragraph on a positive
and constructive note. What I meant was "I think you are wrong and it is
a bugfix, but I do not care overly what we call it as long as we do it."
:)
Do note that my "as long as we do it" is about the direction, not the
patch. There are a few issues with the patch itself, and I just posted a
review.
> I was reacting on the Subject: line because that will what I later
> have to work from when reading shortlog, summarizing changes, etc.
That is a fair point. From the release notes perspective, it probably is
a feature (there is a documentation bug, but it happens to be fixed at
the same time).
-Peff
next prev parent reply other threads:[~2012-07-17 3:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-24 19:38 [PATCH] rev-list: fix place holder %N (notes) in user format Jukka Lehtniemi
2012-03-25 0:55 ` Jeff King
2012-07-16 18:30 ` [PATCH v2] Fix notes handling in rev-list Jukka Lehtniemi
2012-07-16 19:03 ` Junio C Hamano
2012-07-17 3:17 ` Jeff King
2012-07-17 3:40 ` Junio C Hamano
2012-07-17 3:51 ` Jeff King [this message]
2012-07-17 3:46 ` Jeff King
2012-07-17 5:42 ` Junio C Hamano
2012-07-17 21:22 ` Jukka Lehtniemi
2012-07-18 7:21 ` Jeff King
2012-07-18 22:39 ` Junio C Hamano
2012-07-19 11:35 ` Jeff King
2012-07-19 17:20 ` Junio C Hamano
2012-07-19 17:25 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120717035138.GC20945@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jukka.lehtniemi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).