From: Jonathan Nieder <jrnieder@gmail.com>
To: Michael Witten <mfwitten@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Huynh Khoi Nguyen Nguyen
<Huynh-Khoi-Nguyen.Nguyen@ensimag.imag.fr>,
git@vger.kernel.org
Subject: Re: [PATCH 1/3] Testing: XDG config files: Export a suitable `XDG_CONFIG_HOME' environment variable
Date: Tue, 17 Jul 2012 12:57:40 -0500 [thread overview]
Message-ID: <20120717175740.GA14361@burratino> (raw)
In-Reply-To: <679ad82bd4604d1c903f3c2fff2a8cfb-mfwitten@gmail.com>
Hi,
Michael Witten wrote:
> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -544,6 +544,9 @@ rm -fr "$test" || {
> HOME="$TRASH_DIRECTORY"
> export HOME
>
> +XDG_CONFIG_HOME=$HOME/.config
> +export XDG_CONFIG_HOME
> +
I think this is a bad idea. The typical case is for XDG_CONFIG_HOME
not to be set, and we need to make sure git works well in the typical
case.
But the general idea seems sane --- how about
unset VISUAL EMAIL LANGUAGE COLUMNS XDG_CONFIG_HOME $(perl -e '
...
?
next prev parent reply other threads:[~2012-07-17 17:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-17 17:25 [PATCH 0/3] Testing: XDG config files: Fix broken tests Michael Witten
2012-07-17 16:41 ` [PATCH 1/3] Testing: XDG config files: Export a suitable `XDG_CONFIG_HOME' environment variable Michael Witten
2012-07-17 17:57 ` Jonathan Nieder [this message]
2012-07-17 18:14 ` Matthieu Moy
2012-07-17 18:31 ` Junio C Hamano
2012-07-17 16:41 ` [PATCH 2/3] Testing: XDG config files: Use "$HOME" and "$XDG_CONFIG_HOME" explicitly Michael Witten
2012-07-17 18:19 ` Matthieu Moy
2012-07-17 16:41 ` [PATCH 3/3] Testing: XDG config files: Trivial: `xdg' -> `XDG' Michael Witten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120717175740.GA14361@burratino \
--to=jrnieder@gmail.com \
--cc=Huynh-Khoi-Nguyen.Nguyen@ensimag.imag.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mfwitten@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).