From: Jeff King <peff@peff.net>
To: Matthieu Moy <Matthieu.Moy@imag.fr>
Cc: git@vger.kernel.org
Subject: [PATCH 0/4] mediawiki/credential cleanups
Date: Wed, 18 Jul 2012 08:03:07 -0400 [thread overview]
Message-ID: <20120718120307.GA6399@sigill.intra.peff.net> (raw)
Hi Matthieu,
Your initial credential plumbing series went by while I was on vacation,
and I finally got a chance to look at it in more detail. Overall it
looks very good; thank you (and your students) for working on it. It was
especially nice to have a test harness with complete instructions. :)
I came up with a few commits on top. Patches 1 and 2 are cleanups that should
hopefully be non-controversial. Patch 3 is the "url=" attribute we
discussed earlier, and then patch 4 makes use of it in mw-to-git.
[1/4]: docs/credential: minor clarity fixups
[2/4]: mw-to-git: check blank credential attributes via length
[3/4]: credential: convert "url" attribute into its parsed subparts
[4/4]: mw-to-git: use git-credential's URL parser
Documentation/git-credential.txt | 22 ++++++++++++++++------
contrib/mw-to-git/git-remote-mediawiki | 34 +++++-----------------------------
credential.c | 2 ++
3 files changed, 23 insertions(+), 35 deletions(-)
-Peff
next reply other threads:[~2012-07-18 12:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-18 12:03 Jeff King [this message]
2012-07-18 12:04 ` [PATCH 1/4] docs/credential: minor clarity fixups Jeff King
2012-07-18 12:04 ` [PATCH 2/4] mw-to-git: check blank credential attributes via length Jeff King
2012-07-18 12:06 ` [PATCH 3/4] credential: convert "url" attribute into its parsed subparts Jeff King
2012-07-18 12:24 ` Matthieu Moy
2012-07-18 12:25 ` Jeff King
2012-07-18 12:06 ` [PATCH 4/4] mw-to-git: use git-credential's URL parser Jeff King
2012-07-18 12:24 ` Matthieu Moy
2012-07-18 12:28 ` Jeff King
2012-07-18 12:37 ` Matthieu Moy
2012-07-18 12:57 ` Jeff King
2012-07-18 13:03 ` [PATCHv2 " Jeff King
2012-07-18 13:06 ` Matthieu Moy
2012-07-18 13:05 ` [PATCH " Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120718120307.GA6399@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Matthieu.Moy@imag.fr \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).