From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Ramana Kumar <ramana@member.fsf.org>, git@vger.kernel.org
Subject: Re: [PATCH 3/3] commit: give a hint when a commit message has been abandoned
Date: Mon, 23 Jul 2012 16:52:09 -0400 [thread overview]
Message-ID: <20120723205209.GA6745@sigill.intra.peff.net> (raw)
In-Reply-To: <7vzk6qjj7w.fsf@alter.siamese.dyndns.org>
On Mon, Jul 23, 2012 at 01:49:55PM -0700, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > If we launch an editor for the user to create a commit
> > message, they may put significant work into doing so.
> > Typically we try to check common mistakes that could cause
> > the commit to fail early, so that we die before the user
> > goes to the trouble.
> >
> > We may still experience some errors afterwards, though; in
> > this case, the user is given no hint that their commit
> > message has been saved. Let's tell them where it is.
>
> Liberal use of atexit() for something like this makes me cringe
> somewhat.
I don't like it either, but there's not really a better way. The die()
that Ramana triggered in the initial report is deep inside the ident
code. The only other option would be to hook into die_routine, which I
think is even uglier.
-Peff
next prev parent reply other threads:[~2012-07-23 20:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAMej=25=xj61pc+k42dv3byuBqUJzW21Sz+BXwoufqnKwV5Bbg@mail.gmail.com>
2012-07-21 14:26 ` empty ident name trashes commit message Ramana Kumar
2012-07-23 17:27 ` Jeff King
2012-07-23 18:05 ` Ramana Kumar
2012-07-23 18:46 ` Jeff King
2012-07-23 18:48 ` [PATCH 1/3] advice: pass varargs to strbuf_vaddf, not strbuf_addf Jeff King
2012-07-23 18:50 ` [PATCH 2/3] commit: check committer identity more strictly Jeff King
2012-07-23 20:51 ` Junio C Hamano
2012-07-23 20:53 ` Jeff King
2012-07-23 18:52 ` [PATCH 3/3] commit: give a hint when a commit message has been abandoned Jeff King
2012-07-23 20:49 ` Junio C Hamano
2012-07-23 20:52 ` Jeff King [this message]
2012-07-23 21:00 ` Junio C Hamano
2012-07-23 21:13 ` Jeff King
2012-07-23 21:35 ` Junio C Hamano
2012-07-23 21:43 ` Jeff King
2012-07-23 22:09 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120723205209.GA6745@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ramana@member.fsf.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).