From: Jonathan Nieder <jrnieder@gmail.com>
To: Jiang Xin <worldhello.net@gmail.com>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Git List" <git@vger.kernel.org>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
"Thomas Rast" <trast@inf.ethz.ch>
Subject: Re: [PATCH v3 5/7] i18n: am: mark more strings for translation
Date: Tue, 24 Jul 2012 13:16:00 -0500 [thread overview]
Message-ID: <20120724181600.GH2939@burratino> (raw)
In-Reply-To: <d3711733085d683d9a63cff6f615ef3114f2d3c0.1343112786.git.worldhello.net@gmail.com>
Hi,
Jiang Xin wrote:
> Mark additional 3 strings for translation, and reduce one indentation
> level for one gettextln clause introduced in commit de88c1c.
The above description doesn't mention:
[...]
> @@ -387,8 +386,8 @@ do
> -i|--interactive)
> interactive=t ;;
> -b|--binary)
> - echo >&2 "The $1 option has been a no-op for long time, and"
> - echo >&2 "it will be removed. Please do not use it anymore."
> + echo >&2 $(gettext "The -b option has been a no-op for long time, and
> +it will be removed. Please do not use it anymore.")
... that this changes the message when the --binary option is passed.
Before this patch, it says
The --binary option has been a no-op for a long time, and ...
After the patch, it says
The -b option has been a no-op for a long time, and ...
Intentional? That may be a good change or a bad one (I haven't
thought clearly about it), but it seems at least worth mentioning.
Cc-ing Thomas in case he has advice.
Thanks,
Jonathan
next prev parent reply other threads:[~2012-07-24 18:16 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-24 6:59 [PATCH v3 0/7] i18n for git-am, git-rebase and git-merge Jiang Xin
2012-07-24 6:59 ` [PATCH v3 1/7] i18n: New keywords for xgettext extraction from sh Jiang Xin
2012-07-24 6:59 ` [PATCH v3 2/7] i18n: rebase: mark strings for translation Jiang Xin
2012-07-24 6:59 ` [PATCH v3 3/7] i18n: Rewrite gettext messages start with dash Jiang Xin
2012-07-24 6:59 ` [PATCH v3 4/7] Remove obsolete LONG_USAGE which breaks xgettext Jiang Xin
2012-07-24 6:59 ` [PATCH v3 5/7] i18n: am: mark more strings for translation Jiang Xin
2012-07-24 6:59 ` [PATCH v3 6/7] Remove unused and bad gettext block from git-am Jiang Xin
2012-07-24 6:59 ` [PATCH v3 7/7] i18n: merge-recursive: mark strings for translation Jiang Xin
2012-07-24 9:47 ` Stefano Lattarini
2012-07-24 18:27 ` [PATCH v3 6/7] Remove unused and bad gettext block from git-am Jonathan Nieder
2012-07-24 20:40 ` Junio C Hamano
2012-07-24 21:16 ` Martin von Zweigbergk
2012-07-24 21:21 ` Junio C Hamano
2012-07-24 21:25 ` Jonathan Nieder
2012-07-24 22:18 ` Junio C Hamano
2012-07-24 18:16 ` Jonathan Nieder [this message]
2012-07-24 20:43 ` [PATCH v3 5/7] i18n: am: mark more strings for translation Junio C Hamano
2012-07-25 6:38 ` Thomas Rast
2012-07-24 23:00 ` Jiang Xin
2012-07-24 18:08 ` [PATCH v3 4/7] Remove obsolete LONG_USAGE which breaks xgettext Jonathan Nieder
2012-07-24 19:07 ` Junio C Hamano
2012-07-24 9:44 ` [PATCH v3 3/7] i18n: Rewrite gettext messages start with dash Stefano Lattarini
2012-07-24 9:43 ` [PATCH v3 2/7] i18n: rebase: mark strings for translation Stefano Lattarini
2012-07-24 18:01 ` Jonathan Nieder
2012-07-24 18:57 ` Junio C Hamano
2012-07-24 22:49 ` Jiang Xin
2012-07-24 9:38 ` [PATCH v3 1/7] i18n: New keywords for xgettext extraction from sh Stefano Lattarini
2012-07-24 17:46 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120724181600.GH2939@burratino \
--to=jrnieder@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
--cc=trast@inf.ethz.ch \
--cc=worldhello.net@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).