git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Michael G Schwern <schwern@pobox.com>
Cc: git@vger.kernel.org, gitster@pobox.com,
	"Robin H. Johnson" <robbat2@gentoo.org>,
	Eric Wong <normalperson@yhbt.net>,
	Ben Walton <bwalton@artsci.utoronto.ca>
Subject: Re: git-svn SVN 1.7 fix, take 2
Date: Tue, 24 Jul 2012 17:02:08 -0500	[thread overview]
Message-ID: <20120724220207.GA15969@burratino> (raw)
In-Reply-To: <500F17A3.60307@pobox.com>

Hi,

Michael G Schwern wrote:

> I'm trying to bust it up into easier to digest pieces.

I have a crazy idea.  You might not like it, but maybe it's worth giving
it a try.

[...]
> The Git::SVN extraction is more complicated than the rest, so I'll probably do
> that separately and bust it up into a few commits.

All of these changes are supposed to have zero functional effect,
right?

Could you send the first five patches that *are* supposed to have a
functional effect?  I know that they will not apply cleanly to git-svn
from git "master" or on top of each other; that's fine with me.  If
the approach looks right, interested people (read: probably Ben or I :))
can make the corresponding change in the code layout from "master".
Afterwards, we can look into all that refactoring to make later
changes easier.

What do you think?

Thanks,
Jonathan

  parent reply	other threads:[~2012-07-24 22:02 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-24 21:46 git-svn SVN 1.7 fix, take 2 Michael G Schwern
2012-07-24 21:51 ` Junio C Hamano
2012-07-24 23:06   ` Michael G Schwern
2012-07-24 23:12     ` Jonathan Nieder
2012-07-24 22:02 ` Jonathan Nieder [this message]
2012-07-24 22:50   ` Michael G Schwern
2012-07-24 23:03     ` Jonathan Nieder
2012-07-24 23:31     ` Jonathan Nieder
2012-07-24 23:45       ` Junio C Hamano
2012-07-25  1:00         ` Michael G Schwern
2012-07-25  4:53           ` Jonathan Nieder
2012-07-25  5:36             ` Michael G Schwern
2012-07-25  7:14               ` Junio C Hamano
2012-07-25  9:53                 ` Michael G Schwern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120724220207.GA15969@burratino \
    --to=jrnieder@gmail.com \
    --cc=bwalton@artsci.utoronto.ca \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=normalperson@yhbt.net \
    --cc=robbat2@gentoo.org \
    --cc=schwern@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).