From: Jonathan Nieder <jrnieder@gmail.com>
To: Jiang Xin <worldhello.net@gmail.com>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Git List" <git@vger.kernel.org>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
"Stefano Lattarini" <stefano.lattarini@gmail.com>,
"Martin von Zweigbergk" <martin.von.zweigbergk@gmail.com>
Subject: Re: [PATCH v5 6/7] Remove dead code which contains bad gettext block
Date: Wed, 25 Jul 2012 06:30:09 -0500 [thread overview]
Message-ID: <20120725113009.GA4732@burratino> (raw)
In-Reply-To: <b22ea7d7306745555bfd39bf4ff51f485a005a02.1343205009.git.worldhello.net@gmail.com>
Jiang Xin wrote:
> Found this dead code when I examine gettext messages in shell scripts
> start with dash ('-' or '--'). An error will be raised for this case,
> like:
>
> $ gettext "-d option is no longer supported. Do not use."
> gettext: missing arguments
>
> Indead, this code has been left as dead for a long time, as Junathan
> points out:
s/Junathan/Jonathan/, please, unless you are trying to say that both
Junio and I pointed it out at the same time.
next prev parent reply other threads:[~2012-07-25 11:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-25 8:34 [PATCH v5 0/7] i18n for git-am, git-rebase and git-merge Jiang Xin
2012-07-25 8:34 ` [PATCH v5 1/7] i18n: New keywords for xgettext extraction from sh Jiang Xin
2012-07-25 8:34 ` [PATCH v5 2/7] i18n: rebase: mark messages for translation Jiang Xin
2012-07-25 8:34 ` [PATCH v5 3/7] i18n: Rewrite gettext messages start with dash Jiang Xin
2012-07-25 8:34 ` [PATCH v5 4/7] Remove obsolete LONG_USAGE which breaks xgettext Jiang Xin
2012-07-25 8:34 ` [PATCH v5 5/7] i18n: am: mark more strings for translation Jiang Xin
2012-07-25 8:34 ` [PATCH v5 6/7] Remove dead code which contains bad gettext block Jiang Xin
2012-07-25 8:34 ` [PATCH v5 7/7] i18n: merge-recursive: mark strings for translation Jiang Xin
2012-07-25 11:30 ` Jonathan Nieder [this message]
2012-07-25 13:31 ` [PATCH v5 6/7] Remove dead code which contains bad gettext block Jiang Xin
2012-07-26 12:21 ` Nguyen Thai Ngoc Duy
-- strict thread matches above, loose matches on Subject: below --
2012-07-25 14:44 [PATCH v5 0/7] i18n for git-am, git-rebase and git-merge Jiang Xin
2012-07-25 14:44 ` [PATCH v5 1/7] i18n: New keywords for xgettext extraction from sh Jiang Xin
2012-07-25 14:44 ` [PATCH v5 2/7] i18n: rebase: mark messages for translation Jiang Xin
2012-07-25 14:44 ` [PATCH v5 3/7] i18n: Rewrite gettext messages start with dash Jiang Xin
2012-07-25 14:44 ` [PATCH v5 4/7] Remove obsolete LONG_USAGE which breaks xgettext Jiang Xin
2012-07-25 14:44 ` [PATCH v5 5/7] i18n: am: mark more strings for translation Jiang Xin
2012-07-25 14:44 ` [PATCH v5 6/7] Remove dead code which contains bad gettext block Jiang Xin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120725113009.GA4732@burratino \
--to=jrnieder@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=martin.von.zweigbergk@gmail.com \
--cc=pclouds@gmail.com \
--cc=stefano.lattarini@gmail.com \
--cc=worldhello.net@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).