From: Jonathan Nieder <jrnieder@gmail.com>
To: "Michael G. Schwern" <schwern@pobox.com>
Cc: git@vger.kernel.org, gitster@pobox.com, robbat2@gentoo.org,
bwalton@artsci.utoronto.ca, normalperson@yhbt.net
Subject: Re: [PATCH 3/3] The Makefile.PL will now find .pm files itself.
Date: Wed, 25 Jul 2012 16:31:12 -0500 [thread overview]
Message-ID: <20120725213112.GG4732@burratino> (raw)
In-Reply-To: <20120725211143.GA5455@burratino>
Jonathan Nieder wrote:
> Michael G. Schwern wrote:
>> --- a/perl/Makefile.PL
>> +++ b/perl/Makefile.PL
>> @@ -2,6 +2,10 @@ use strict;
>> use warnings;
>> use ExtUtils::MakeMaker;
>> use Getopt::Long;
>> +use File::Find;
>> +
>> +# Don't forget to update the perl/Makefile, too.
>> +# Don't forget to test with NO_PERL_MAKEMAKER=YesPlease
[...]
> Who are these comments in perl/Makefile.PL addressed to? Why would
> such a person be looking at perl/Makefile.PL? Sorry to sound like a
> broken record, but I don't think these questions were answered yet.
To maybe answer my own question: are these comments addressed to
people making other changes to perl/Makefile.PL, rather than people
adding new modules?
That could make sense --- it would just be a change in purpose from
the original comments. It also means there's no reminder when adding
new modules to list them in perl/Makefile any more, but that's
probably inevitable as long as we don't have a perl coding style
document.
Hoping that clarifies,
Jonathan
next prev parent reply other threads:[~2012-07-25 21:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-25 3:21 Teach Makefile.PL to find .pm files on its own Michael G. Schwern
2012-07-25 3:21 ` [PATCH 1/3] Quiet warning if Makefile.PL is run with -w and no --localedir Michael G. Schwern
2012-07-25 3:21 ` [PATCH 2/3] Don't lose Error.pm if $@ gets clobbered Michael G. Schwern
2012-07-25 3:21 ` [PATCH 3/3] The Makefile.PL will now find .pm files itself Michael G. Schwern
2012-07-25 21:11 ` Jonathan Nieder
2012-07-25 21:31 ` Jonathan Nieder [this message]
2012-07-25 21:49 ` Michael G Schwern
2012-07-25 21:56 ` Jonathan Nieder
2012-07-25 16:56 ` Teach Makefile.PL to find .pm files on its own Junio C Hamano
2012-07-25 20:26 ` Michael G Schwern
2012-07-25 20:32 ` Junio C Hamano
2012-07-25 21:12 ` Michael G Schwern
2012-07-25 22:19 ` Junio C Hamano
2012-07-25 22:56 ` Michael G Schwern
2012-07-25 23:29 ` Junio C Hamano
2012-07-25 23:37 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120725213112.GG4732@burratino \
--to=jrnieder@gmail.com \
--cc=bwalton@artsci.utoronto.ca \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=normalperson@yhbt.net \
--cc=robbat2@gentoo.org \
--cc=schwern@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).