From: Jonathan Nieder <jrnieder@gmail.com>
To: Michael G Schwern <schwern@pobox.com>
Cc: Eric Wong <normalperson@yhbt.net>,
git@vger.kernel.org, gitster@pobox.com, robbat2@gentoo.org,
bwalton@artsci.utoronto.ca
Subject: Re: [PATCH 1/4] Extract some utilities from git-svn to allow extracting Git::SVN.
Date: Wed, 25 Jul 2012 19:26:12 -0500 [thread overview]
Message-ID: <20120726002612.GA3038@burratino> (raw)
In-Reply-To: <501088EC.50405@pobox.com>
Michael G Schwern wrote:
> This is rapidly getting into the weeds. Regardless of the debate below, what
> would you like me to do? Switch indentation to tabs and resubmit? AFAIK only
> the new tests are affected.
Yes, please do so at some point before the final submission. (If
there's more feedback coming for this generation of the patches, no
need to resubmit right away unless you want to. In general, when
getting review a useful strategy can be to discuss proposed changes
and batch them until the discussion seems to have died down and only
then resubmit the next version.)
If we want to switch indentation styles (not a traditional way to
start working with an existing project, but whatever), that would be a
separate change, affecting all the code consistently.
Thanks,
Jonathan
next prev parent reply other threads:[~2012-07-26 0:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-25 6:01 Move Git::SVN into its own .pm file Michael G. Schwern
2012-07-25 6:01 ` [PATCH 1/4] Extract some utilities from git-svn to allow extracting Git::SVN Michael G. Schwern
2012-07-25 21:24 ` Eric Wong
2012-07-25 22:39 ` Michael G Schwern
2012-07-25 23:08 ` Eric Wong
2012-07-26 0:01 ` Michael G Schwern
2012-07-26 0:25 ` Eric Wong
2012-07-26 0:26 ` Jonathan Nieder [this message]
2012-07-25 6:01 ` [PATCH 2/4] Prepare Git::SVN for extraction into its own file Michael G. Schwern
2012-07-25 6:01 ` [PATCH 4/4] Move initialization of Git::SVN variables into Git::SVN Michael G. Schwern
2012-07-25 21:15 ` Move Git::SVN into its own .pm file Jonathan Nieder
2012-07-25 21:56 ` Michael G Schwern
-- strict thread matches above, loose matches on Subject: below --
2012-07-26 23:22 Extract Git::SVN from git-svn, take 2 Michael G. Schwern
2012-07-26 23:22 ` [PATCH 1/4] Extract some utilities from git-svn to allow extracting Git::SVN Michael G. Schwern
2012-07-27 5:18 ` Junio C Hamano
2012-07-27 8:19 ` Michael G Schwern
2012-07-27 11:34 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120726002612.GA3038@burratino \
--to=jrnieder@gmail.com \
--cc=bwalton@artsci.utoronto.ca \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=normalperson@yhbt.net \
--cc=robbat2@gentoo.org \
--cc=schwern@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).