git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jiang Xin <worldhello.net@gmail.com>, Git List <git@vger.kernel.org>
Subject: [PATCH 0/6] t7502 fixes
Date: Thu, 26 Jul 2012 16:26:44 -0400	[thread overview]
Message-ID: <20120726202644.GA15043@sigill.intra.peff.net> (raw)
In-Reply-To: <20120726193359.GA28711@sigill.intra.peff.net>

On Thu, Jul 26, 2012 at 03:33:59PM -0400, Jeff King wrote:

> I'm close to finished with a series that I think will at least make it
> better. Stay tuned.

Here it is. I was able to replicate the original problem by munging my
/etc/passwd, and I've confirmed that this series fixes it by skipping
the related test. I also added in a test for the early-quit behavior
introduced by f20f387. It can't run everywhere, of course, but it seems
we have at least one tester whose system will run it (and I did confirm
that it works with my munged /etc/passwd).

One other option is that we could introduce a
GIT_PRETEND_THIS_IS_MY_GECOS_NAME variable. That would let us wrong both
sides of the test on all systems. I just hate to add an interface that
will be carried around in production code just for the sake of a test.

  [1/6]: t7502: clean up fake_editor tests
  [2/6]: t7502: properly quote GIT_EDITOR
  [3/6]: t7502: narrow checks for author/committer name in template
  [4/6]: t7502: drop confusing test_might_fail call
  [5/6]: t7502: handle systems where auto-identity is broken
  [6/6]: t7502: test early quit from commit with bad ident

-Peff

  parent reply	other threads:[~2012-07-26 20:26 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-26  6:27 Test "t/t7502-commit.sh" failed Jiang Xin
2012-07-26 13:03 ` Jeff King
2012-07-26 16:34   ` Junio C Hamano
2012-07-26 17:12     ` Jeff King
2012-07-26 19:25       ` Junio C Hamano
2012-07-26 19:33         ` Jeff King
2012-07-26 20:04           ` Junio C Hamano
2012-07-26 20:26           ` Jeff King [this message]
2012-07-26 20:27             ` [PATCH 1/6] t7502: clean up fake_editor tests Jeff King
2012-07-26 20:28             ` [PATCH 2/6] t7502: properly quote GIT_EDITOR Jeff King
2012-07-26 20:30             ` [PATCH 3/6] t7502: narrow checks for author/committer name in template Jeff King
2012-07-26 20:31             ` [PATCH 4/6] t7502: drop confusing test_might_fail call Jeff King
2012-07-26 20:32             ` [PATCH 5/6] t7502: handle systems where auto-identity is broken Jeff King
2012-07-26 20:32             ` [PATCH 6/6] t7502: test early quit from commit with bad ident Jeff King
2012-07-26 21:15             ` [PATCH 0/6] t7502 fixes Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120726202644.GA15043@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=worldhello.net@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).