From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Thomas Rast" <trast@student.ethz.ch>,
"Christoph Miebach" <christoph.miebach@web.de>,
git@vger.kernel.org, "Jürgen Rühle" <j-r@online.de>
Subject: Re: bug (?) in send email
Date: Mon, 30 Jul 2012 12:34:40 -0400 [thread overview]
Message-ID: <20120730163440.GC16701@sigill.intra.peff.net> (raw)
In-Reply-To: <7vpq7ds1hu.fsf@alter.siamese.dyndns.org>
On Mon, Jul 30, 2012 at 08:38:21AM -0700, Junio C Hamano wrote:
> > I think this patch would be a better match for what RFC2047 specifies.
> > On the one hand it avoids substituting _ outside of encodings, but OTOH
> > it also handles more than one encoded-word.
>
> Yeah, I think it is an improvement.
>
> I however wonder if the captured pattern for $2 should be minimized
> with ? at the end, i.e. "..\?q\?(.*?)\?="?
Yeah, definitely. "?=" cannot appear inside (it would need to be
quoted).
> > It still does not handle
> > the case where there are several encoded-words of *different* encodings,
> > but who would do such a crazy thing?
>
> Even if somebody did so, it wouldn't have worked, and to make it
> work, the sub and its caller (there is only one caller that actually
> cares what the original encoding was) needs to be rethought anyway,
> so I do not think it matters.
>
> It may deserve an in-code NEEDSWORK comment, though.
I rambled about this in much more detail in another reply, but the gist
of it is that yes, that is the right step for now.
-Peff
next prev parent reply other threads:[~2012-07-30 16:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-28 21:33 bug (?) in send email Christoph Miebach
2012-07-30 10:38 ` Christoph Miebach
2012-07-30 12:30 ` Thomas Rast
2012-07-30 15:38 ` Junio C Hamano
2012-07-30 16:34 ` Jeff King [this message]
2012-07-30 16:32 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120730163440.GC16701@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=christoph.miebach@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j-r@online.de \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).