From: Jeff King <peff@peff.net>
To: "Daniel Graña" <dangra@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] Improve tests for detached worktree in git-submodule
Date: Mon, 30 Jul 2012 12:39:07 -0400 [thread overview]
Message-ID: <20120730163907.GA18109@sigill.intra.peff.net> (raw)
In-Reply-To: <1343664610-479-1-git-send-email-dangra@gmail.com>
On Mon, Jul 30, 2012 at 01:10:10PM -0300, Daniel Graña wrote:
> Subject: Re: [PATCH] Improve tests for detached worktree in git-submodule
>
> Signed-off-by: Daniel Graña <dangra@gmail.com>
The space between the subject and your S-o-b is an excellent place to
explain the rationale for your commit.
How are we improving them? What cases or classes of failure does this
catch that the original did not? It may be because I have not been
following this topic closely, but reading the patch, I am not sure what
the purpose is. Please make life easier for reviewers by telling us what
to expect and why before we even get to the patch.
-Peff
next prev parent reply other threads:[~2012-07-30 16:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-30 16:10 [PATCH] Improve tests for detached worktree in git-submodule Daniel Graña
2012-07-30 16:39 ` Jeff King [this message]
[not found] ` <CAHCkQtNyNGBm8Z8FP7BybVOW0zQNgpxjwW_akLepYfLc-U+0cg@mail.gmail.com>
2012-07-30 17:06 ` Fwd: " Daniel Graña
2012-07-30 17:02 ` Junio C Hamano
2012-07-30 17:18 ` Daniel Graña
2012-07-30 17:44 ` Junio C Hamano
2012-07-30 17:51 ` Junio C Hamano
2012-07-30 17:51 ` Daniel Graña
2012-07-30 18:09 ` Junio C Hamano
2012-07-30 18:15 ` Daniel Graña
2012-07-30 17:43 ` Daniel Graña
2012-07-30 17:50 ` Daniel Graña
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120730163907.GA18109@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=dangra@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).