Re: [RFC 0/16] Introduce index file format version 5

[Thomas Gummerer <t.gummerer@gmail.com>]

On 08/03, Thomas Rast wrote:
> Thomas Gummerer <t.gummerer@gmail.com> writes:
> 
> > [PATCH 01/16] Modify cache_header to prepare for other index formats
> > [PATCH 02/16] Modify read functions to prepare for other index
> > [PATCH 03/16] Modify match_stat_basic to prepare for other index
> > [PATCH 04/16] Modify write functions to prepare for other index
> > [PATCH 05/16] t2104: Don't fail when index version is 5
> > [PATCH 06/16] t3700: sleep for 1 second, to avoid interfering with
> > [PATCH 07/16] Add documentation of the index-v5 file format
> > [PATCH 08/16] Make in-memory format aware of stat_crc
> > [PATCH 09/16] Read index-v5
> > [PATCH 10/16] Read resolve-undo data
> > [PATCH 11/16] Read cache-tree in index-v5
> > [PATCH 12/16] Write index-v5
> > [PATCH 13/16] Write index-v5 cache-tree data
> > [PATCH 14/16] Write resolve-undo data for index-v5
> > [PATCH 15/16] update-index.c: add a force-rewrite option
> > [PATCH 16/16] p0002-index.sh: add perf test for the index formats
> 
> I haven't had time for more than a cursory look yet, but good job on the
> splits.  This is a large improvement over what you had in Zurich!

Thanks, it was easier when seeing the code, instead of just thinking
about them of the top of my head.

> One thing that you need to be more careful about is attribution of the
> source code.  Credit is very important because it's the only thing
> people get for their OSS work.  For some patches you received lots of
> input and help by many people.  For example, the documentation patch
> that casts the format in stone (or will, when it's finished), should
> have "Helped-by:" for *at least* Michael, Junio, and Duy.  You should
> dig in the ML archives for other people who may have contributed ideas.
> 
> Also, anything that contains nontrivial code from me needs my S-o-b; off
> the top of my head that's just 16/16, which AFAICS is even completely
> unchanged (!) and needs to come with a From (and my S-o-b).  (I'm not
> going to be anal about any of the work we did in Zurich, let's just
> classify that as "help" like above.)

My apologies, i forgot to add them. I'll make sure to include all
credits in the re-roll.