From: Jeff King <peff@peff.net>
To: "Michał Kiedrowicz" <michal.kiedrowicz@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Fix 'No newline...' annotation in rewrite diffs.
Date: Fri, 3 Aug 2012 12:02:30 -0400 [thread overview]
Message-ID: <20120803160229.GA13094@sigill.intra.peff.net> (raw)
In-Reply-To: <loom.20120803T094115-721@post.gmane.org>
On Fri, Aug 03, 2012 at 07:49:47AM +0000, Michał Kiedrowicz wrote:
> Jeff King <peff <at> peff.net> writes:
>
> > - for i in $(seq 1 $GIT_PERF_REPEAT_COUNT); do
> > + for i in $("$PERL_PATH" -le "print for 1..$GIT_PERF_REPEAT_COUNT"); do
>
> Maybe you could introduce "test_seq" instead.
I don't have a strong preference, as there are only two callsites. Do
you want to make a patch?
-Peff
next prev parent reply other threads:[~2012-08-03 16:03 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-02 21:11 [PATCH] Fix 'No newline...' annotation in rewrite diffs Adam Butcher
2012-08-02 21:33 ` Jeff King
2012-08-02 21:52 ` Junio C Hamano
2012-08-02 22:14 ` Jeff King
2012-08-03 7:49 ` Michał Kiedrowicz
2012-08-03 16:02 ` Jeff King [this message]
2012-08-03 16:46 ` Junio C Hamano
2012-08-03 17:00 ` Jeff King
2012-08-03 19:57 ` [PATCH] tests: Introduce test_seq Michał Kiedrowicz
2012-08-03 20:02 ` Jeff King
2012-08-03 20:53 ` Junio C Hamano
2012-08-03 22:02 ` Jeff King
2012-08-03 22:09 ` Michał Kiedrowicz
2012-08-04 16:38 ` Johannes Sixt
2012-08-04 23:05 ` Junio C Hamano
2012-08-06 17:52 ` Michał Kiedrowicz
2012-08-06 20:16 ` Jeff King
2012-08-03 22:21 ` Michał Kiedrowicz
2012-08-03 22:48 ` Junio C Hamano
2012-08-03 23:08 ` Jeff King
2012-08-03 23:12 ` Junio C Hamano
2012-08-04 8:14 ` Michał Kiedrowicz
2012-08-04 22:10 ` Adam Butcher
2012-08-03 20:04 ` Michał Kiedrowicz
2012-08-03 20:07 ` Jeff King
2012-08-03 20:12 ` Michał Kiedrowicz
2012-08-03 20:38 ` Michał Kiedrowicz
2012-08-03 20:41 ` Jeff King
2012-08-02 22:22 ` [PATCH] Fix 'No newline...' annotation in rewrite diffs Adam Butcher
2012-08-02 22:00 ` Junio C Hamano
2012-08-02 22:58 ` Adam Butcher
2012-08-04 21:07 ` Adam Butcher
2012-08-05 1:26 ` Junio C Hamano
2012-08-05 7:06 ` [PATCH] Fix '\ No " Adam Butcher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120803160229.GA13094@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=michal.kiedrowicz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).