From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Ben Walton <bwalton@artsci.utoronto.ca>,
git@vger.kernel.org, rctay89@gmail.com, schwab@linux-m68k.org
Subject: Re: [PATCH] Enable HAVE_DEV_TTY for Solaris
Date: Tue, 7 Aug 2012 00:03:26 -0400 [thread overview]
Message-ID: <20120807040326.GA18682@sigill.intra.peff.net> (raw)
In-Reply-To: <7v4nofxt89.fsf@alter.siamese.dyndns.org>
On Mon, Aug 06, 2012 at 08:43:02PM -0700, Junio C Hamano wrote:
> Ben Walton <bwalton@artsci.utoronto.ca> writes:
>
> > Now that git_terminal_prompt can cleanly interact with /dev/tty on
> > Solaris, enable HAVE_DEV_TTY so that this code path is used for
> > credential reading instead of relying on the crippled getpass().
> >
> > Signed-off-by: Ben Walton <bwalton@artsci.utoronto.ca>
> > ---
> >
> > This is a follow up to Jeff's patch that fixes git_terminal_prompt on
> > Solaris. I don't have 5.6 or 5.7 for testing but I believe this
> > should be valid for both of those releases as well.
>
> So which direction do you guys want to go? Use the "bidirectional
> stdio with fseek()" for now, with the expectation that Tay's other
> series will rewrite it to fd based one?
I think so. The stdio fix is short and obviously correct, and then Tay
can either refactor or not as he sees fit for his topic (although if we
do switch to just a terminal_can_prompt() interface and get rid of the
term_t ugliness, then there is not even any need to do the rewrite).
-Peff
next prev parent reply other threads:[~2012-08-07 4:03 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-05 23:17 [PATCH] Avoid crippled getpass function on Solaris Ben Walton
2012-08-06 1:56 ` Tay Ray Chuan
2012-08-06 2:41 ` Ben Walton
2012-08-06 1:59 ` Junio C Hamano
2012-08-06 2:35 ` Ben Walton
2012-08-06 19:39 ` Jeff King
2012-08-06 19:57 ` Junio C Hamano
2012-08-06 21:31 ` Ben Walton
2012-08-06 21:34 ` Jeff King
2012-08-06 22:09 ` Ben Walton
2012-08-06 22:31 ` Jeff King
2012-08-06 22:39 ` Ben Walton
2012-08-06 22:42 ` Jeff King
2012-08-06 23:31 ` Ben Walton
2012-08-07 0:01 ` Jeff King
2012-08-06 23:05 ` Andreas Schwab
2012-08-07 0:23 ` Jeff King
2012-08-07 0:35 ` Jeff King
2012-08-07 2:18 ` Tay Ray Chuan
2012-08-07 3:01 ` Ben Walton
2012-08-07 3:07 ` [PATCH] Enable HAVE_DEV_TTY for Solaris Ben Walton
2012-08-07 3:43 ` Junio C Hamano
2012-08-07 4:03 ` Jeff King [this message]
2012-08-07 4:10 ` Jeff King
2012-08-07 15:31 ` Ben Walton
2012-08-08 14:13 ` Erik Faye-Lund
2012-08-08 21:05 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120807040326.GA18682@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=bwalton@artsci.utoronto.ca \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=rctay89@gmail.com \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).