From: Jeff King <peff@peff.net>
To: Brandon Casey <drafnel@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH 2/2] prune.c: only print informational message in show_only or verbose mode
Date: Tue, 7 Aug 2012 02:03:11 -0400 [thread overview]
Message-ID: <20120807060311.GB13222@sigill.intra.peff.net> (raw)
In-Reply-To: <CA+sFfMdVhTwAFLUgrO-mLBh8apG-5X1OJKCN9xgq3-N+1RBrvg@mail.gmail.com>
On Mon, Aug 06, 2012 at 10:44:07PM -0700, Brandon Casey wrote:
> On Mon, Aug 6, 2012 at 10:32 PM, Jeff King <peff@peff.net> wrote:
> >
> > This seems like a band-aid. The real problem is that auto-gc can
> > interfere with the pack protocol, which it should not be allowed to do,
> > no matter what it produces.
> >
> > We could fix that root cause with this patch (on top of your 1/2):
>
> Anyone else? :)
Sorry to gang up on you. :)
I still think your 2/2 is worth doing independently, though. It is silly
that git-prune will not mention pruned objects without "-v", but will
mention temporary files. They should be in the same category.
-Peff
next prev parent reply other threads:[~2012-08-07 6:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-05 1:55 Did we break receive-pack recently? Junio C Hamano
2012-08-06 1:37 ` Brandon Casey
2012-08-06 3:32 ` Brandon Casey
2012-08-07 5:01 ` [PATCH 1/2] t/t5400: demonstrate breakage caused by informational message from prune Brandon Casey
2012-08-07 5:01 ` [PATCH 2/2] prune.c: only print informational message in show_only or verbose mode Brandon Casey
2012-08-07 5:28 ` Junio C Hamano
2012-08-07 5:34 ` Junio C Hamano
2012-08-07 5:44 ` Brandon Casey
2012-08-07 6:03 ` Jeff King [this message]
2012-08-07 6:33 ` Brandon Casey
2012-08-07 15:41 ` Junio C Hamano
2012-08-07 21:44 ` Junio C Hamano
2012-08-07 21:59 ` Jeff King
2012-08-07 22:55 ` Brandon Casey
2012-08-07 5:32 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120807060311.GB13222@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=drafnel@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).