From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
To: Chris West <git@goeswhere.com>, git@vger.kernel.org
Subject: Re: [PATCH] gitweb: Add support for gravatar-ssl
Date: Thu, 09 Aug 2012 21:36:46 +0200 [thread overview]
Message-ID: <20120809193655.7418D13F8069@mailgw.unict.it> (raw)
In-Reply-To: 20120809184210.GA27795@goeswhere.com
Chris West (Faux) wrote:
> Teach gitweb to allow 'avatar' to be set to 'gravatar-ssl', switching
> to the https://secure.gravatar.com url form, to avoid mixed content
> warnings when serving gitweb over https, with gravatar enabled.
> ---
> I'd alternatively propose always using the https:// form of the URL,
> but it seems significantly slower, so it's probably best to let people
> pick to continue using the insecure version.
Rather than introducing a new, separate setting, wouldn't it be better
to have the gravatar URL be automatically decided based on the current
gitweb URL? (use the ssl gravar url when the current protocol is https,
and the standard http url otherwise)
next prev parent reply other threads:[~2012-08-09 19:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-09 18:42 [PATCH] gitweb: Add support for gravatar-ssl Chris West (Faux)
2012-08-09 19:36 ` Giuseppe Bilotta [this message]
2012-08-09 19:53 ` git
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120809193655.7418D13F8069@mailgw.unict.it \
--to=giuseppe.bilotta@gmail.com \
--cc=git@goeswhere.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).