Re: [PATCH 0/4] jk/version-string and google code

[Jeff King <peff@peff.net>]

On Fri, Aug 10, 2012 at 08:34:45AM -0700, Junio C Hamano wrote:

> Jeff King <peff@peff.net> writes:
> 
> > Ugh, the jk/version-string topic breaks fetching from Google Code. With
> > my patch, the client unconditionally sends an "agent=foo" capability,
> > but the server does not like seeing the unknown capability and ends the
> > connection (I'm guessing with some kind of internal exception, since it
> > spews "Internal server error" over the protocol channel).
> 
> The fix looks sane and the right thing to do.
> 
> I've been using 'next' and started seeing this breakage when pushing
> to code.google.com only a few days ago.  My reflog tells that
> ff5effd (include agent identifier in capability string, 2012-08-03)
> was merged to my everyday-work branch on this Monday, which is more
> or less consistent with what I am observing.

Thanks for confirming the push side. I have been running with the patch
for months, but only recently happened to try cloning something from
code.google.com. I assumed the push side had the same problem, but did
not want to make a new project just to test (and it seemed fairly
obvious that it would have the same issue).

It was pure coincidence that it happened at the same time you were
graduating the topic to next. But I'm glad I was able to catch it before
anybody started complaining. :)

-Peff