From: Jeff King <peff@peff.net>
To: Dave Borowitz <dborowitz@google.com>
Cc: Junio C Hamano <gitster@pobox.com>,
"Shawn O. Pearce" <spearce@spearce.org>,
git@vger.kernel.org
Subject: Re: [PATCH 0/4] jk/version-string and google code
Date: Fri, 10 Aug 2012 14:08:36 -0400 [thread overview]
Message-ID: <20120810180836.GA29597@sigill.intra.peff.net> (raw)
In-Reply-To: <CAD0k6qTnQ+b8e2wt4WZ2HhOdsKXzcMkGbUZBkbw2j6_mQdE9GA@mail.gmail.com>
On Fri, Aug 10, 2012 at 11:06:08AM -0700, Dave Borowitz wrote:
> > I asked the folks who run code.google.com and they are indeed seeing
> > something like these in their logs:
> >
> > >> Client asked for capability agent=git/1.7.12.rc2.79.g86c1702 that was not advertised.
>
> FWIW, this error comes from Dulwich:
> https://github.com/jelmer/dulwich/blob/25250c1694dac343d469742aeafa139f37fc4ec6/dulwich/server.py#L196
Thanks for the data point. I knew you guys ran some custom code, so I
wasn't sure how widespread this is. The fact that other dulwich-based
servers would see the same issue makes me doubly sure that my fix is the
right direction.
> So any servers running Dulwich would be affected by this...though I'm
> not aware of any large-scale Dulwich installations other than Google
> Code.
I'd rather not break small-scale installations, either. :)
-Peff
next prev parent reply other threads:[~2012-08-10 18:08 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-10 7:53 [PATCH 0/4] jk/version-string and google code Jeff King
2012-08-10 7:57 ` [PATCH 1/4] send-pack: fix capability-sending logic Jeff King
2012-08-10 7:57 ` [PATCH 2/4] do not send client agent unless server does first Jeff King
2012-08-10 19:45 ` Junio C Hamano
2012-08-10 21:09 ` Jeff King
2012-08-10 7:58 ` [PATCH 3/4] connect: learn to parse capabilities with values Jeff King
2012-08-10 8:06 ` Eric Sunshine
2012-08-10 20:01 ` Junio C Hamano
2012-08-10 21:15 ` Jeff King
2012-08-10 21:55 ` Junio C Hamano
2012-08-13 19:03 ` Junio C Hamano
2012-08-13 19:07 ` [PATCH 4/4] fetch-pack: mention server version with verbose output Junio C Hamano
2012-08-13 19:43 ` Junio C Hamano
2012-08-13 20:54 ` Jeff King
2012-08-13 21:07 ` Junio C Hamano
2012-08-13 21:07 ` Jeff King
2012-08-13 21:09 ` Junio C Hamano
2012-08-13 21:11 ` Jeff King
2012-08-14 1:59 ` Jeff King
2012-08-14 2:02 ` Jeff King
2012-08-14 4:56 ` Junio C Hamano
2012-08-10 7:59 ` Jeff King
2012-08-10 15:34 ` [PATCH 0/4] jk/version-string and google code Junio C Hamano
2012-08-10 17:46 ` Jeff King
2012-08-10 18:52 ` Junio C Hamano
2012-08-10 21:50 ` Jeff King
2012-08-10 22:29 ` Shawn Pearce
2012-08-10 22:36 ` Junio C Hamano
2012-08-10 15:37 ` Junio C Hamano
2012-08-10 18:06 ` Dave Borowitz
2012-08-10 18:08 ` Jeff King [this message]
2012-08-10 18:13 ` Dave Borowitz
2012-08-10 18:25 ` Jeff King
2012-08-10 21:25 ` Junio C Hamano
2012-08-10 21:35 ` Jeff King
2012-08-10 21:42 ` Junio C Hamano
2012-08-10 19:11 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120810180836.GA29597@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=dborowitz@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).