From: Pete Wyckoff <pw@padd.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Matthew Korich <matthew@korich.net>, git@vger.kernel.org
Subject: Re: [PATCH 0/5] git p4: fix branch detection with --use-client-spec
Date: Sun, 12 Aug 2012 10:04:49 -0400 [thread overview]
Message-ID: <20120812140449.GA5635@padd.com> (raw)
In-Reply-To: <7v4no8hgc0.fsf@alter.siamese.dyndns.org>
gitster@pobox.com wrote on Sat, 11 Aug 2012 21:41 -0700:
> Pete Wyckoff <pw@padd.com> writes:
>
> > matthew@korich.net wrote on Fri, 10 Aug 2012 12:14 -0700:
> >> Using git p4 on git version 1.7.12.rc2 has path issues. Standard
> >> clone/sync ops apparently place detected master and branches on
> >> independent and parallel directory structures instead of git branches.
> >> See http://stackoverflow.com/q/11893688/1588831 for a full demo of the problem.
> >
> > Thank you for the detailed report. It is a bug in 1.7.12-rc2.
>
> Do you mean "a feature that was present in 1.7.11 without this bug
> was broken when used with 1.7.12-rc2"? Or do you mean "this bug
> exists in 1.7.12-rc2 (older versions may or may not have it, but I
> am stressing that it is not fixed)"?
>
> The description for [PATCH 5/5] blames v1.7.9-rc0~4^2~1, which tells
> me it is the latter. And if that were the case, and if this were in
> the area of the system I oversee, I wouldn't push it to the upcoming
> release at this late in the cycle, when I do not know what other
> things it might break while fixing this bug (in other words, a fix
> to an old bug is not an execuse to introduce a regression).
>
> But git-p4 is not in my area, so if you meant this should go in the
> upcoming 1.7.12 release, I'll queue them directly on 'master'.
>
> Please tell me what your preference is.
Good point about "already released bugs". I confirmed it was
broken in 1.7.11 too, so there's no reason to rush this fix into
1.7.12. If you could queue it up in pu, that would be great.
Otherwise I'll resubmit after the upcoming release.
Thanks,
-- Pete
next prev parent reply other threads:[~2012-08-12 14:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-10 19:14 git-p4 migrates perforce “main” branch into git branches as subdirectories (doubled code in git branches) Matthew Korich
2012-08-11 16:51 ` [PATCH 0/5] git p4: fix branch detection with --use-client-spec Pete Wyckoff
2012-08-11 16:55 ` [PATCH 1/5] git p4 test: move client_view() function to library Pete Wyckoff
2012-08-11 16:55 ` [PATCH 2/5] git p4 test: add broken --use-client-spec --detect-branches tests Pete Wyckoff
2012-08-11 16:55 ` [PATCH 3/5] git p4: set self.branchPrefixes in initialization Pete Wyckoff
2012-08-11 16:55 ` [PATCH 4/5] git p4: do wildcard decoding in stripRepoPath Pete Wyckoff
2012-08-11 16:55 ` [PATCH 5/5] git p4: make branch detection work with --use-client-spec Pete Wyckoff
2012-08-12 4:41 ` [PATCH 0/5] git p4: fix branch detection " Junio C Hamano
2012-08-12 14:04 ` Pete Wyckoff [this message]
2012-08-12 19:30 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120812140449.GA5635@padd.com \
--to=pw@padd.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=matthew@korich.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).