From: Jeff King <peff@peff.net>
To: mhagger@alum.mit.edu
Cc: Junio C Hamano <gitster@pobox.com>,
Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>,
Thomas Rast <trast@student.ethz.ch>,
Alexey Muranov <alexey.muranov@gmail.com>,
git@vger.kernel.org
Subject: Re: [RFC 2/3] Delete reflogs for dead references to allow pruning
Date: Tue, 21 Aug 2012 04:33:45 -0400 [thread overview]
Message-ID: <20120821083345.GB13252@sigill.intra.peff.net> (raw)
In-Reply-To: <1345310086-20089-3-git-send-email-mhagger@alum.mit.edu>
On Sat, Aug 18, 2012 at 07:14:45PM +0200, mhagger@alum.mit.edu wrote:
> From: Michael Haggerty <mhagger@alum.mit.edu>
>
> This test is broken by "retain reflogs for deleted refs". Explicitly
> delete the reflogs in the graveyard to allow the corresponding commits
> to be pruned.
>
> Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
> ---
>
> Probably there should be a "git reflog" subcommand to do this.
>
> t/t9300-fast-import.sh | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/t/t9300-fast-import.sh b/t/t9300-fast-import.sh
> index 266ae30..dc6c67d 100755
> --- a/t/t9300-fast-import.sh
> +++ b/t/t9300-fast-import.sh
> @@ -1700,6 +1700,7 @@ INPUT_END
>
> test_expect_success 'P: verbatim SHA gitlinks' '
> git branch -D sub &&
> + rm -rf .git/logs/graveyard &&
I think "git reflog expire --expire=now refs/heads/sub" would be less
leaky. That didn't work in my initial version, but it obviously should.
I'll include a tweaked version of your fix when I re-roll.
-Peff
next prev parent reply other threads:[~2012-08-21 8:34 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-19 7:30 Feature request: fetch --prune by default Alexey Muranov
2012-07-19 11:55 ` Jeff King
2012-07-19 14:03 ` Dan Johnson
2012-07-19 15:11 ` Stefan Haller
2012-08-16 23:22 ` Junio C Hamano
2012-08-21 6:51 ` Jeff King
2013-06-20 19:22 ` Sam Roberts
2012-07-19 16:21 ` Alexey Muranov
2012-07-19 17:34 ` Konstantin Khomoutov
2012-07-19 21:20 ` Alexey Muranov
2012-07-19 21:57 ` Alexey Muranov
2012-07-20 7:11 ` Johannes Sixt
2012-07-20 7:28 ` Alexey Muranov
2012-08-16 23:27 ` Junio C Hamano
2012-07-19 16:40 ` Alexey Muranov
2012-07-19 16:48 ` Dan Johnson
2012-07-19 16:51 ` Alexey Muranov
2012-07-19 21:32 ` [RFC/PATCH 0/3] reflog graveyard Jeff King
2012-07-19 21:33 ` [PATCH 1/3] retain reflogs for deleted refs Jeff King
2012-07-19 22:23 ` Alexey Muranov
2012-07-20 14:26 ` Jeff King
2012-07-20 14:32 ` Alexey Muranov
2012-07-19 22:36 ` Junio C Hamano
2012-07-20 14:43 ` Jeff King
2012-07-20 15:07 ` Jeff King
2012-07-20 15:39 ` Junio C Hamano
2012-07-20 15:42 ` Junio C Hamano
2012-07-20 15:50 ` Jeff King
2012-08-16 23:29 ` Junio C Hamano
2012-07-20 9:49 ` Michael Haggerty
2012-07-20 15:44 ` Jeff King
2012-07-20 16:37 ` Johannes Sixt
2012-07-20 17:09 ` Jeff King
2012-07-22 11:03 ` Alexey Muranov
2012-07-26 12:47 ` Nguyen Thai Ngoc Duy
2012-07-26 16:26 ` Alexey Muranov
2012-07-26 16:41 ` Matthieu Moy
2012-07-26 16:59 ` Jeff King
2012-07-26 17:24 ` Alexey Muranov
2012-07-26 17:46 ` Junio C Hamano
2012-07-26 17:52 ` Jeff King
2012-07-22 11:10 ` Alexey Muranov
2012-07-22 11:12 ` Alexey Muranov
2012-07-22 13:14 ` Jeff King
2012-07-22 14:40 ` Alexey Muranov
2012-07-22 15:50 ` Jeff King
2012-07-20 16:32 ` Johannes Sixt
2012-08-18 17:14 ` [RFC 0/3] Reflogs for deleted refs: fix breakage and suggest namespace change mhagger
2012-08-18 17:14 ` [RFC 1/3] t9300: format test in modern style prior to modifying it mhagger
2012-08-18 17:14 ` [RFC 2/3] Delete reflogs for dead references to allow pruning mhagger
2012-08-21 8:33 ` Jeff King [this message]
2012-08-18 17:14 ` [RFC 3/3] Change naming convention for the reflog graveyard mhagger
2012-08-18 20:39 ` [RFC 0/3] Reflogs for deleted refs: fix breakage and suggest namespace change Junio C Hamano
2012-08-18 21:11 ` Alexey Muranov
2012-08-19 0:02 ` Junio C Hamano
2012-08-19 7:07 ` Alexey Muranov
2012-08-19 7:15 ` Alexey Muranov
2012-08-19 11:28 ` Alexey Muranov
2012-08-19 17:38 ` Junio C Hamano
2012-08-19 22:09 ` Alexey Muranov
2012-08-20 0:26 ` Junio C Hamano
2012-08-20 1:01 ` Junio C Hamano
2012-08-20 11:32 ` Alexey Muranov
2012-08-20 11:57 ` Alexey Muranov
2012-08-19 13:19 ` Michael Haggerty
2012-08-19 16:27 ` Junio C Hamano
2012-08-21 8:27 ` Jeff King
2012-08-21 17:56 ` Junio C Hamano
2012-07-19 21:33 ` [PATCH 2/3] teach sha1_name to look in graveyard reflogs Jeff King
2012-07-19 22:39 ` Junio C Hamano
2012-07-20 15:53 ` Jeff King
2012-07-22 20:53 ` Junio C Hamano
2012-07-19 21:33 ` [PATCH 3/3] add tests for reflogs of deleted refs Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120821083345.GB13252@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=alexey.muranov@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=martin.von.zweigbergk@gmail.com \
--cc=mhagger@alum.mit.edu \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).