From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Sitaram Chamarty <sitaramc@gmail.com>,
John Arthorne <arthorne.eclipse@gmail.com>,
git <git@vger.kernel.org>
Subject: Re: receive.denyNonNonFastForwards not denying force update
Date: Tue, 21 Aug 2012 17:53:50 -0400 [thread overview]
Message-ID: <20120821215350.GA22215@sigill.intra.peff.net> (raw)
In-Reply-To: <7va9xndibh.fsf@alter.siamese.dyndns.org>
On Tue, Aug 21, 2012 at 02:52:02PM -0700, Junio C Hamano wrote:
> Junio C Hamano <gitster@pobox.com> writes:
>
> > Modulo the above "you might want to turn the call to warn() to
> > another helper that can be used from elsewhere", this patch looks
> > perfect to me.
>
> And that "modulo" is fairly simple if we wanted to go that route.
>
> attr.c | 2 +-
> dir.c | 2 +-
> git-compat-util.h | 3 +++
> wrapper.c | 7 ++++++-
> 4 files changed, 11 insertions(+), 3 deletions(-)
Yeah, that looks fine to me if you want to squash it in.
-Peff
next prev parent reply other threads:[~2012-08-21 21:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAHgXSop42qWcAEGn6=og8Pistv_Jrwhgcnv3B_ORVtSMi1fCHA@mail.gmail.com>
2012-08-20 13:33 ` receive.denyNonNonFastForwards not denying force update John Arthorne
2012-08-20 17:05 ` Junio C Hamano
2012-08-21 0:52 ` Sitaram Chamarty
2012-08-21 1:22 ` Junio C Hamano
2012-08-21 1:53 ` Brandon Casey
2012-08-21 2:16 ` Jay Soffian
2012-08-21 3:46 ` Junio C Hamano
2012-08-21 1:57 ` Jeff King
2012-08-21 3:49 ` Junio C Hamano
2012-08-21 6:10 ` Jeff King
2012-08-21 6:22 ` Jeff King
2012-08-21 6:26 ` Jeff King
2012-08-21 6:31 ` Jeff King
2012-08-21 16:50 ` Junio C Hamano
2012-08-21 19:33 ` Jeff King
2012-08-21 16:43 ` Junio C Hamano
2012-08-21 21:52 ` Junio C Hamano
2012-08-21 21:53 ` Jeff King [this message]
2012-08-21 2:08 ` Sitaram Chamarty
2012-09-10 13:24 ` John Arthorne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120821215350.GA22215@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=arthorne.eclipse@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sitaramc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).