From: Jeff King <peff@peff.net>
To: Jeffrey Middleton <jefromi@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: approxidate parsing for bad time units
Date: Fri, 7 Sep 2012 09:54:52 -0400 [thread overview]
Message-ID: <20120907135452.GA1290@sigill.intra.peff.net> (raw)
In-Reply-To: <CAFE6XREG5-gwjzvyP9r_hfyY3bWSV2=Bjv9ZbXkejXQRoqYERA@mail.gmail.com>
On Thu, Sep 06, 2012 at 02:01:30PM -0700, Jeffrey Middleton wrote:
> I'm generally very happy with the fuzzy parsing. It's a great feature
> that is designed to and in general does save users a lot of time and
> thought. In this case I don't think it does. The problems are:
> (1) It's not ignoring things it can't understand, it's silently
> interpreting them in a useless way.
Right, but we would then need to come up with a list of things it _does_
understand. So right now I can say "6 June" or "6th of June" or even "6
de June", and it works because we just ignore the cruft in the middle.
So I think you'd need to either whitelist what everybody is typing, or
blacklist some common typos (or convince people to be stricter in what
they type).
> So I do think it's worth improving. (Yes, I know, send patches; I'll
> think about it.)
You read my mind. :)
-Peff
next prev parent reply other threads:[~2012-09-07 13:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 16:24 approxidate parsing for bad time units Jeffrey Middleton
2012-09-06 20:36 ` Junio C Hamano
2012-09-06 21:01 ` Jeffrey Middleton
2012-09-07 13:54 ` Jeff King [this message]
2012-09-10 21:07 ` Jeffrey Middleton
2012-09-10 21:19 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120907135452.GA1290@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jefromi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).