From: Jeff King <peff@peff.net>
To: Erik Faye-Lund <kusmabite@gmail.com>
Cc: git@vger.kernel.org, msysgit@googlegroups.com
Subject: Re: [PATCH/RFC] test-lib: add support for colors without tput
Date: Fri, 14 Sep 2012 13:44:39 -0400 [thread overview]
Message-ID: <20120914174439.GA16657@sigill.intra.peff.net> (raw)
In-Reply-To: <1347640905-1400-1-git-send-email-kusmabite@gmail.com>
On Fri, Sep 14, 2012 at 06:41:45PM +0200, Erik Faye-Lund wrote:
> diff --git a/t/test-lib.sh b/t/test-lib.sh
> index 78c4286..7d1b34b 100644
> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -129,6 +129,20 @@ export _x05 _x40 _z40 LF
> # This test checks if command xyzzy does the right thing...
> # '
> # . ./test-lib.sh
> +
> +if ! which tput > /dev/null ; then
Testing the return value of "which" is not portable (I know, it's
insane; SunOS is the common offender). Use "type" instead.
-Peff
--
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.
You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en
next prev parent reply other threads:[~2012-09-14 17:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-14 16:41 [PATCH/RFC] test-lib: add support for colors without tput Erik Faye-Lund
2012-09-14 16:54 ` Erik Faye-Lund
2012-09-14 16:58 ` Erik Faye-Lund
2012-09-14 17:08 ` Elia Pinto
2012-09-14 17:11 ` Erik Faye-Lund
2012-09-14 17:12 ` Elia Pinto
2012-09-14 17:16 ` Erik Faye-Lund
2012-09-14 17:28 ` Johannes Sixt
2012-09-14 17:31 ` Erik Faye-Lund
2012-09-14 18:11 ` Erik Faye-Lund
2012-09-14 19:15 ` Johannes Sixt
2012-09-17 17:39 ` Johannes Sixt
2012-09-14 17:30 ` Junio C Hamano
2012-09-14 17:42 ` Erik Faye-Lund
2012-09-14 18:03 ` Junio C Hamano
2012-09-14 17:44 ` Jeff King [this message]
2012-09-14 17:52 ` Erik Faye-Lund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120914174439.GA16657@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=kusmabite@gmail.com \
--cc=msysgit@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).