git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Alex Riesen <raa.lkml@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
	Junio C Hamano <gitster@pobox.com>,
	"Michael G. Schwern" <schwern@pobox.com>
Subject: Re: Parallel make failed in perl/perl.mak
Date: Mon, 17 Sep 2012 15:46:40 -0400	[thread overview]
Message-ID: <20120917194640.GA24888@sigill.intra.peff.net> (raw)
In-Reply-To: <CALxABCbzr653R4aCc_YOXNZYo8Zeu8WiU72OmyyMyz5WR+p6gw@mail.gmail.com>

On Mon, Sep 17, 2012 at 08:13:35PM +0200, Alex Riesen wrote:

> mv: cannot stat `perl.mak': No such file or directory
> mv: cannot move `perl.mak' to `perl.mak.old': No such file or directory
> [...]
> I wasn't able to reproduce it, so this message is the only thing I have.
> It was the first compilation after I merged the current master
> (v1.7.12-464-g83379df).

This is probably the same bug that we've been hunting for years:

  April 2009:
  http://article.gmane.org/gmane.comp.version-control.git/117710

  October 2010:
  http://article.gmane.org/gmane.comp.version-control.git/158251

  March 2011:
  http://article.gmane.org/gmane.comp.version-control.git/170153

I proposed a patch in the middle one, but of course we have no idea if
it works or not, since the problem is so hard to reproduce.

> Probably the old perl.mak is the problem, and the only thing I can think
> for reasons why it wasn't regenerated is this:
> 
> diff --git a/perl/Makefile b/perl/Makefile
> index 15d96fc..766d02a 100644
> --- a/perl/Makefile
> +++ b/perl/Makefile
> @@ -79,7 +79,7 @@ $(makfile): ../GIT-CFLAGS Makefile
>  	echo instlibdir: >> $@
>  	echo '	echo $(instdir_SQ)' >> $@
>  else
> -$(makfile): Makefile.PL ../GIT-CFLAGS
> +$(makfile): Makefile.PL ../GIT-CFLAGS Makefile
>  	$(PERL_PATH) $< PREFIX='$(prefix_SQ)' INSTALL_BASE=''
> --localedir='$(localedir_SQ)'
>  endif
> 
> Could someone please take a look at it?

That only takes effect if NO_PERL_MAKEMAKER is set, and I think we see
the bug even when it is not set. Also, I'm not clear on what part of
Makefile that command would depend on (the GIT-CFLAGS dependency should
cover the directory parameters).

-Peff

      reply	other threads:[~2012-09-17 19:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-17 18:13 Parallel make failed in perl/perl.mak Alex Riesen
2012-09-17 19:46 ` Jeff King [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120917194640.GA24888@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=raa.lkml@gmail.com \
    --cc=schwern@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).