git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Eric Wong <normalperson@yhbt.net>
Cc: git@vger.kernel.org, gitster@pobox.com, robbat2@gentoo.org,
	bwalton@artsci.utoronto.ca,
	"Michael G. Schwern" <schwern@pobox.com>
Subject: Re: [PATCH/RFC] git-svn: use path accessor for Git::SVN objects
Date: Tue, 18 Sep 2012 07:29:42 -0700	[thread overview]
Message-ID: <20120918142941.GA2925@elie.Belkin> (raw)
In-Reply-To: <20120918000931.GB17939@dcvr.yhbt.net>

Eric Wong wrote:

> The accessors should improve maintainability and enforce
> consistent access to Git::SVN objects.
>
> Signed-off-by: Eric Wong <normalperson@yhbt.net>
> ---
>   (RFC since I could've missed something)
[...]
>  git-svn.perl       | 2 +-
>  perl/Git/SVN/Ra.pm | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

I think that's all of them, so for what it's worth,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

  reply	other threads:[~2012-09-18 14:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-18  0:09 [PATCH/RFC] git-svn: use path accessor for Git::SVN objects Eric Wong
2012-09-18 14:29 ` Jonathan Nieder [this message]
2012-09-18 18:10   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120918142941.GA2925@elie.Belkin \
    --to=jrnieder@gmail.com \
    --cc=bwalton@artsci.utoronto.ca \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=normalperson@yhbt.net \
    --cc=robbat2@gentoo.org \
    --cc=schwern@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).