From: Paul Mackerras <paulus@samba.org>
To: Stefan Haller <stefan@haller-berlin.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] gitk: Synchronize highlighting in file view when scrolling diff
Date: Wed, 19 Sep 2012 09:46:11 +1000 [thread overview]
Message-ID: <20120918234611.GA5544@bloggs.ozlabs.ibm.com> (raw)
In-Reply-To: <1347947874-38597-1-git-send-email-stefan@haller-berlin.de>
On Tue, Sep 18, 2012 at 07:57:54AM +0200, Stefan Haller wrote:
> Whenever the diff pane scrolls, highlight the corresponding file in the
> file list on the right. For a large commit with many files and long
> per-file diffs, this makes it easier to keep track of what you're looking
> at.
I like this as far as it goes, but the one criticism I would have is
that when you find a string (using the "Search" button), the filename
that gets highlighted is often not the file in which the string was
found (because the highlighting is based on the top line visible in
the text window), which could be confusing.
Can you think of a way to solve that too? Perhaps make the
highlighting based on the currently highlighted instance of the search
string, if there is one, otherwise based on the top line visible?
Paul.
next prev parent reply other threads:[~2012-09-19 0:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-18 5:57 [PATCH] gitk: Synchronize highlighting in file view when scrolling diff Stefan Haller
2012-09-18 18:23 ` Peter Oberndorfer
2012-09-19 9:57 ` [PATCH v2] " Stefan Haller
2012-09-18 23:46 ` Paul Mackerras [this message]
2012-09-19 14:28 ` [PATCH] " Marc Branchaud
2012-09-19 18:17 ` [PATCH v3] " Stefan Haller
2012-09-23 6:58 ` Paul Mackerras
2012-09-24 5:51 ` Stefan Haller
2012-10-26 22:03 ` [PATCH] gitk: Do not select file list entries during diff loading Peter Oberndorfer
2012-10-29 8:56 ` Stefan Haller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120918234611.GA5544@bloggs.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=git@vger.kernel.org \
--cc=stefan@haller-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).