From: Jeff King <peff@peff.net>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: Jeroen Meijer <jjgmeijer@hotmail.com>, git@vger.kernel.org
Subject: Re: possible bug in autocompletion
Date: Wed, 19 Sep 2012 13:43:36 -0400 [thread overview]
Message-ID: <20120919174336.GA11699@sigill.intra.peff.net> (raw)
In-Reply-To: <CAMP44s2X5-BUyLtkTqGMa6w5K6uT25YLEp+Q2TdVR_qCObOpeA@mail.gmail.com>
On Wed, Sep 19, 2012 at 07:08:09PM +0200, Felipe Contreras wrote:
> On Tue, Jul 17, 2012 at 2:12 PM, Jeff King <peff@peff.net> wrote:
>
> > --- a/contrib/completion/git-completion.bash
> > +++ b/contrib/completion/git-completion.bash
> > @@ -261,7 +261,12 @@ __gitcomp ()
> > __gitcomp_nl ()
> > {
> > local IFS=$'\n'
> > - COMPREPLY=($(compgen -P "${2-}" -S "${4- }" -W "$1" -- "${3-$cur}"))
> > + local words=$1
> > + words=${words//\\/\\\\}
> > + words=${words//\$/\\\$}
> > + words=${words//\'/\\\'}
> > + words=${words//\"/\\\"}
> > + COMPREPLY=($(compgen -P "${2-}" -S "${4- }" -W "$words" -- "${3-$cur}"))
> > }
>
> What about something like this?
>
> local words
> printf -v words "%q" "$w"
> COMPREPLY=($(compgen -P "${2-}" -S "${4- }" -W "$words" -- "${3-$cur}"))
Thanks, I didn't know about bash's internal printf magic. That is a much
more elegant solution.
Care to wrap it up in a patch?
-Peff
next prev parent reply other threads:[~2012-09-19 17:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-17 9:10 possible bug in autocompletion Jeroen Meijer
2012-07-17 12:12 ` Jeff King
2012-09-19 17:08 ` Felipe Contreras
2012-09-19 17:43 ` Jeff King [this message]
2012-09-19 18:16 ` Felipe Contreras
2012-09-19 18:23 ` Felipe Contreras
2012-09-19 19:55 ` Jeff King
2012-09-19 23:08 ` Felipe Contreras
2012-09-19 23:43 ` Jeff King
2012-09-19 17:58 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120919174336.GA11699@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=jjgmeijer@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).