From: Jeff King <peff@peff.net>
To: Kevin Ballard <kevin@sb.org>
Cc: Junio C Hamano <gitster@pobox.com>,
Drew Northup <n1xim.email@gmail.com>,
gitList <git@vger.kernel.org>,
Matthieu.Moy@imag.fr, andy@aeruder.net, chriscool@tuxfamily.org,
dmellor@whistlingcat.com, dpmcgee@gmail.com, fonseca@diku.dk,
freku045@student.liu.se, marius@trolltech.com,
namhyung@gmail.com, rene.scharfe@lsrfire.ath.cx, s-beyer@gmx.net,
trast@inf.ethz.ch
Subject: Re: [PATCH] Documentation/git-blame.txt: --follow is a NO-OP
Date: Wed, 19 Sep 2012 16:37:38 -0400 [thread overview]
Message-ID: <20120919203738.GA24383@sigill.intra.peff.net> (raw)
In-Reply-To: <C07F05AC-8FBF-4F09-AF13-A291181A06D9@sb.org>
On Wed, Sep 19, 2012 at 01:31:50PM -0700, Kevin Ballard wrote:
> > I am a little lukewarm on my patch if only because of the precedent it
> > sets. There are a trillion options that revision.c parses that are not
> > necessarily meaningful or implemented for sub-commands that piggy-back
> > on its option parser. I'm not sure we want to get into manually
> > detecting and disallowing each one in every caller.
>
> I tend to agree with your final sentiment there. But the point that
> users may not realize that blame already follows is also valid. Perhaps
> we should catch --follow, as in your patch, but instead of saying that
> it's an unknown argument, just print out a helpful message saying blame
> already follows renames (and then continue with the blame anyway, so
> as to not set a precedent to abort on unknown-but-currently-accepted
> flags).
Sure, that would probably make sense. Care to roll a patch with
suggested wording?
-Peff
next prev parent reply other threads:[~2012-09-19 20:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 7:02 git blame --follow norbert.nemec
2012-09-06 9:58 ` Jeff King
2012-09-06 10:12 ` norbert.nemec
2012-09-06 15:13 ` Jeff King
2012-09-19 2:48 ` [PATCH] Documentation/git-blame.txt: --follow is a NO-OP Drew Northup
2012-09-19 4:38 ` Junio C Hamano
2012-09-19 18:27 ` Jeff King
2012-09-19 19:36 ` Junio C Hamano
2012-09-19 19:42 ` Jeff King
2012-09-19 20:31 ` Kevin Ballard
2012-09-19 20:37 ` Jeff King [this message]
2012-09-19 21:09 ` Kevin Ballard
2012-09-21 19:09 ` Re* " Junio C Hamano
2012-09-21 21:00 ` Junio C Hamano
2012-09-20 0:05 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120919203738.GA24383@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Matthieu.Moy@imag.fr \
--cc=andy@aeruder.net \
--cc=chriscool@tuxfamily.org \
--cc=dmellor@whistlingcat.com \
--cc=dpmcgee@gmail.com \
--cc=fonseca@diku.dk \
--cc=freku045@student.liu.se \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kevin@sb.org \
--cc=marius@trolltech.com \
--cc=n1xim.email@gmail.com \
--cc=namhyung@gmail.com \
--cc=rene.scharfe@lsrfire.ath.cx \
--cc=s-beyer@gmx.net \
--cc=trast@inf.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).