From: Paul Mackerras <paulus@samba.org>
To: Stefan Haller <stefan@haller-berlin.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/2] gitk: Better highlighting of search results
Date: Sun, 23 Sep 2012 16:59:47 +1000 [thread overview]
Message-ID: <20120923065947.GB15889@bloggs.ozlabs.ibm.com> (raw)
In-Reply-To: <1348299625-90207-1-git-send-email-stefan@haller-berlin.de>
On Sat, Sep 22, 2012 at 09:40:23AM +0200, Stefan Haller wrote:
> Here's something that has been bugging me for a long time: when using
> the incremental search feature, it's hard to tell what happens when
> clicking the Search button (or type Ctrl-S) repeatedly. It does have
> the concept of a "current" search hit, and Ctrl-S advances to the next
> one; however, you can't see it because all search hits are highlighted
> in the same way (yellow). So when there are multiple hits visible on
> the current page, it will at some point scroll down to reveal more
> hits, but it's impossible to predict when this will happen.
>
> To improve this, we highlight the current search in orange and the
> other ones in yellow (like Chrome does it when you search on a Web
> page).
Nice, thanks - applied.
Paul.
prev parent reply other threads:[~2012-09-23 7:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-22 7:40 [PATCH 0/2] gitk: Better highlighting of search results Stefan Haller
2012-09-22 7:40 ` [PATCH 1/2] gitk: Highlight current search hit in orange Stefan Haller
2012-09-22 7:40 ` [PATCH 2/2] gitk: Highlight first search result immediately on incremental search Stefan Haller
2012-09-23 6:59 ` Paul Mackerras [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120923065947.GB15889@bloggs.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=git@vger.kernel.org \
--cc=stefan@haller-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).