git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@samba.org>
To: Stefan Haller <stefan@haller-berlin.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] gitk: Work around empty back and forward images when buttons are disabled
Date: Sun, 23 Sep 2012 17:00:15 +1000	[thread overview]
Message-ID: <20120923070015.GC15889@bloggs.ozlabs.ibm.com> (raw)
In-Reply-To: <1348300008-90717-1-git-send-email-stefan@haller-berlin.de>

On Sat, Sep 22, 2012 at 09:46:48AM +0200, Stefan Haller wrote:
> On Mac, the back and forward buttons show an empty rectange instead of
> a grayed-out arrow when they are disabled. The reason is a Tk bug on Mac
> that causes disabled images not to draw correctly (not to draw at all,
> that is); see
> <https://groups.google.com/forum/?fromgroups=#!topic/comp.lang.tcl/V-nW1JBq0eU>.
> 
> To work around this, we explicitly provide gray images for the disabled
> state; I think this looks better than the default stipple effect that you
> get on Windows as well, but that may be a matter of taste.
> 
> Signed-off-by: Stefan Haller <stefan@haller-berlin.de>

Thanks, applied.

Paul.

      reply	other threads:[~2012-09-23  7:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-22  7:46 [PATCH] gitk: Work around empty back and forward images when buttons are disabled Stefan Haller
2012-09-23  7:00 ` Paul Mackerras [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120923070015.GC15889@bloggs.ozlabs.ibm.com \
    --to=paulus@samba.org \
    --cc=git@vger.kernel.org \
    --cc=stefan@haller-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).