From: Jeff King <peff@peff.net>
To: Tobias Ulmer <tobiasu@tmux.org>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] silence git gc --auto --quiet output
Date: Mon, 24 Sep 2012 14:36:41 -0400 [thread overview]
Message-ID: <20120924183641.GA15858@sigill.intra.peff.net> (raw)
In-Reply-To: <20120924024024.GA12700@tin.tmux.org>
On Mon, Sep 24, 2012 at 04:40:24AM +0200, Tobias Ulmer wrote:
> When --quiet is requested, gc --auto should not display messages unless
> there is an error.
> [...]
> - if (quiet)
> - fprintf(stderr, _("Auto packing the repository for optimum performance.\n"));
That makes sense to me. I wonder if we should also be more careful about
propagating quiet flags from the callers of "gc --auto". For example,
"git am -q" will run "git gc --auto" without the quiet flag at the end,
potentially producing unwanted output.
-Peff
next prev parent reply other threads:[~2012-09-24 18:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 2:40 [PATCH] silence git gc --auto --quiet output Tobias Ulmer
2012-09-24 18:36 ` Jeff King [this message]
2012-09-24 22:42 ` Junio C Hamano
2012-09-24 22:53 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120924183641.GA15858@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=tobiasu@tmux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).