git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Michael J Gruber <git@drmicha.warpmail.net>
Cc: Junio C Hamano <gitster@pobox.com>,
	Joshua Jensen <jjensen@workspacewhiz.com>,
	Johannes Sixt <j6t@kdbg.org>,
	"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: Quickly searching for a note
Date: Mon, 24 Sep 2012 20:42:23 -0400	[thread overview]
Message-ID: <20120925004223.GC19586@sigill.intra.peff.net> (raw)
In-Reply-To: <505F2598.7080704@drmicha.warpmail.net>

On Sun, Sep 23, 2012 at 05:07:04PM +0200, Michael J Gruber wrote:

> > If we linked with an embeddable scripting language interpreter
> > (e.g. lua, tcl, guile, ...), it may be a more practical enhancement,
> > though.
> > 
> 
> Yes, the idea is "extend, don't embed" the other way round, so to say. I
> still think extending "git log" so that it can call a script with commit
> info already in the environment gives a more convenient approach then
> "embedding git rev-list" into your own script. It's not more performant,
> of course.

I think Junio is going the other way than you think. That is, you still
run rev-list, but rather than call a sub-program, you call a snippet of
an embeddable script. Which is the same idea as yours, but theoretically
way faster.

> I just see many more requests of the type "grep notes" coming, i.e.
> limitting based on other commit info, or in a different way then already
> possible. Just image you want to find out who's responsible for those
> commits in git.git with subject lengths > 100 ;)

Like this:

  git log --lua-filter='return subject().len > 100'

? :)

-Peff

  reply	other threads:[~2012-09-25  0:42 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-21 14:41 Quickly searching for a note Joshua Jensen
2012-09-21 15:10 ` Andreas Schwab
2012-09-21 18:34   ` Joshua Jensen
2012-09-21 17:21 ` Junio C Hamano
2012-09-21 18:29   ` Joshua Jensen
2012-09-21 20:04     ` Junio C Hamano
2012-09-21 20:25       ` Joshua Jensen
2012-09-21 20:50         ` Johannes Sixt
2012-09-21 21:10           ` Joshua Jensen
2012-09-21 23:37             ` Jeff King
2012-09-21 23:51               ` Junio C Hamano
2012-09-22 16:10                 ` Michael J Gruber
2012-09-22 20:23                   ` Junio C Hamano
2012-09-23 15:07                     ` Michael J Gruber
2012-09-25  0:42                       ` Jeff King [this message]
2012-09-25  7:24                         ` Michael J Gruber
2012-09-25  0:38                     ` Jeff King
2012-09-25 16:19                       ` Junio C Hamano
2012-09-22  4:51 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120925004223.GC19586@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@drmicha.warpmail.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=j6t@kdbg.org \
    --cc=jjensen@workspacewhiz.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).